Maniphest T349010

Remove trident-hack font-size from Vector
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Description

Background
https://phabricator.wikimedia.org/T102364#9195445

The trident hack is used to fix a rounding error in IE11 font-sizes. Given that IE11 now falls into Grade C (basic) browser support category, this hack can be removed from the Vector 2022 skin. It can remain in Vector Legacy since that skin targets older browsers.

Outcome:

[x ] The Less variable @font-size-base--trident-hack is removed
[ x] All instances of font-size: @font-size-base--trident-hack; usage is removed from Vector 2022

QA

Pixel tests should sufficiently cover any potential regressions related to this work.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove trident-hack font-size from Vector	mediawiki/skins/Vector	master	+1 -9

Customize query in gerrit

Related Objects

Mentioned In: T349323: Verify 1.42.0-wmf.3 deployment
Mentioned Here: T102364: Provide a workaround to modern Microsoft browser's 'font-size .css settings in relative units with values to three or more decimal places' miscalculation bug

Event Timeline

Jdrewniak created this task.Oct 16 2023, 4:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2023, 4:41 PM

Jdlrobson moved this task from Incoming to Web Team FY2023-24 Q2 Sprint 2 on the Web-Team-Backlog-Archived board.Oct 16 2023, 5:40 PM

Jdlrobson edited projects, added Web-Team-Backlog-Archived (Web Team FY2023-24 Q2 Sprint 2); removed Web-Team-Backlog-Archived.

ovasileva triaged this task as Low priority.Oct 19 2023, 5:23 PM

ovasileva set the point value for this task to 1.

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q2 Sprint 2) board.

• Mabualruz claimed this task.Oct 26 2023, 3:49 PM

• Mabualruz moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q2 Sprint 2) board.

Change 968974 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] Remove trident-hack font-size from Vector

https://gerrit.wikimedia.org/r/968974

gerritbot added a project: Patch-For-Review.Oct 27 2023, 11:56 AM

• Mabualruz moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q2 Sprint 2) board.Oct 27 2023, 11:57 AM

Jdrewniak claimed this task.Oct 27 2023, 1:51 PM

Jdrewniak added a subscriber: • Mabualruz.

Change 968974 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove trident-hack font-size from Vector

https://gerrit.wikimedia.org/r/968974

Maintenance_bot removed a project: Patch-For-Review.Oct 27 2023, 2:31 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.3; 2023-10-31).Oct 27 2023, 3:00 PM

Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q2 Sprint 2) board.Oct 27 2023, 4:55 PM

Only references are in legacy Vector:
https://codesearch.wmcloud.org/search/?q=font-size-base--trident-hack&files=&excludeFiles=&repos=

There are no regressions in Pixel.

Edtadros mentioned this in T349323: Verify 1.42.0-wmf.3 deployment.Nov 13 2023, 12:27 AM