Page MenuHomePhabricator

Remove trident-hack font-size from Vector
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Background
https://phabricator.wikimedia.org/T102364#9195445

The trident hack is used to fix a rounding error in IE11 font-sizes. Given that IE11 now falls into Grade C (basic) browser support category, this hack can be removed from the Vector 2022 skin. It can remain in Vector Legacy since that skin targets older browsers.

Outcome:

  • [x ] The Less variable @font-size-base--trident-hack is removed
  • [ x] All instances of font-size: @font-size-base--trident-hack; usage is removed from Vector 2022

QA

  • Pixel tests should sufficiently cover any potential regressions related to this work.

Details

Event Timeline

ovasileva set the point value for this task to 1.

Change 968974 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] Remove trident-hack font-size from Vector

https://gerrit.wikimedia.org/r/968974

Change 968974 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove trident-hack font-size from Vector

https://gerrit.wikimedia.org/r/968974

Jdlrobson updated the task description. (Show Details)
Jdlrobson subscribed.

Only references are in legacy Vector:
https://codesearch.wmcloud.org/search/?q=font-size-base--trident-hack&files=&excludeFiles=&repos=

There are no regressions in Pixel.