Page MenuHomePhabricator
Create Task
Maniphest T349057

User rights: Users can run unsaved code on the implementation page
Closed, ResolvedPublic
Actions

Description

Description

Currently there is no special right for running edited and unsaved code from the implementation page. Anyone who can access the implementation edit page (any logged in user) can edit the implementation code and run the unsaved version.

We should maybe control this particular action with a specific execute right, which we can easily control on mediawiki configuration if we need to.

Completion checklist

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Allow logged out users to run FunctionEvaluator widgetmediawiki/extensions/WikiLambdawmf/1.42.0-wmf.1+276 -29
Allow logged out users to run FunctionEvaluator widgetmediawiki/extensions/WikiLambdamaster+276 -29
Customize query in gerrit

Related Objects
Search...

Event Timeline

gengh created this task.Oct 17 2023, 6:30 AM
gengh mentioned this in T349054: Adjust and improve Wikifunctions user rights grants for General Availability.
Jdforrester-WMF added a parent task: T349054: Adjust and improve Wikifunctions user rights grants for General Availability.Oct 17 2023, 2:05 PM
gengh claimed this task.Oct 18 2023, 1:19 PM
gerritbot added a comment.Oct 19 2023, 2:40 PM

Change 967224 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Allow logged out users to run FunctionEvaluator widget

https://gerrit.wikimedia.org/r/967224

gerritbot added a project: Patch-For-Review.Oct 19 2023, 2:40 PM
Jdforrester-WMF changed the task status from Open to In Progress.Oct 19 2023, 4:39 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF moved this task from To Triage to In Progress on the Abstract Wikipedia team board.
gerritbot added a comment.Oct 20 2023, 1:27 PM

Change 967224 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Allow logged out users to run FunctionEvaluator widget

https://gerrit.wikimedia.org/r/967224

Maintenance_bot removed a project: Patch-For-Review.Oct 20 2023, 1:30 PM
Jdforrester-WMF moved this task from In Progress to To deploy on the Abstract Wikipedia team board.Oct 20 2023, 1:32 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 20 2023, 2:00 PM
gerritbot added a comment.Oct 25 2023, 1:16 PM

Change 968319 had a related patch set uploaded (by Jforrester; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@wmf/1.42.0-wmf.1] Allow logged out users to run FunctionEvaluator widget

https://gerrit.wikimedia.org/r/968319

gerritbot added a project: Patch-For-Review.Oct 25 2023, 1:16 PM
gerritbot added a comment.Oct 25 2023, 1:34 PM

Change 968319 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@wmf/1.42.0-wmf.1] Allow logged out users to run FunctionEvaluator widget

https://gerrit.wikimedia.org/r/968319

Stashbot added a comment.Oct 25 2023, 1:35 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-25T13:34:59Z] <jforrester@deploy2002> Started scap: Backport for [[gerrit:968319|Allow logged out users to run FunctionEvaluator widget (T301670 T349055 T349057)]]

Stashbot mentioned this in T301670: Create a placeholder Roles module in Vuex ahead of future role work.Oct 25 2023, 1:35 PM
Stashbot mentioned this in T349055: User rights: Users can run functions.
Jdforrester-WMF edited projects, added MW-1.42-notes (1.42.0-wmf.1; 2023-10-17); removed MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 25 2023, 1:37 PM
Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.
Stashbot added a comment.Oct 25 2023, 1:53 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-25T13:53:56Z] <jforrester@deploy2002> jforrester: Backport for [[gerrit:968319|Allow logged out users to run FunctionEvaluator widget (T301670 T349055 T349057)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.Oct 25 2023, 2:11 PM
Stashbot added a comment.Oct 25 2023, 2:30 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-25T14:30:10Z] <jforrester@deploy2002> sync-world aborted: Backport for [[gerrit:968319|Allow logged out users to run FunctionEvaluator widget (T301670 T349055 T349057)]] (duration: 55m 10s)

Jdforrester-WMF closed this task as Resolved.Nov 29 2023, 5:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits