Page MenuHomePhabricator

Prevent future us from hating now-us - change table name
Closed, ResolvedPublic

Description

I just realised we have created a camel case table for external identifiers - I think we should change that while we can because I think the case will trip us up in future

  • see how the table name is declared as 'External_Identifiers' rather than a more consistent civicrm_external_identifiers or wmf_external_identifiers
'External_Identifiers' => [
  'group' => [
    'extends' => 'Contact',
    'name' => 'External_Identifiers',
    'table_name' => 'External_Identifiers',

@Damilare @Ejegg

Event Timeline

AKanji-WMF subscribed.

Let's not hate ourselves, let's bring it into sprint U for maintenance window

Change 969388 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Rename External_Identifiers table to wmf_external_contact_identifiers

https://gerrit.wikimedia.org/r/969388

Change 969388 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Rename External_Identifiers table to wmf_external_contact_identifiers

https://gerrit.wikimedia.org/r/969388

Change 970385 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Clean up unused civi tables

https://gerrit.wikimedia.org/r/970385

Change 970385 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Clean up unused civi tables

https://gerrit.wikimedia.org/r/970385

XenoRyet set Final Story Points to 2.