| Tchanders | |
| Oct 18 2023, 3:57 PM |
| F41514023: 2023-11-17_08-29-10.png | |
| Nov 17 2023, 4:52 PM |
| F41512533: 2023-11-16_15-14-43.png | |
| Nov 17 2023, 12:34 AM |
| F41512540: 2023-11-16_15-21-52.png | |
| Nov 17 2023, 12:34 AM |
| F41512538: 2023-11-16_16-28-40.png | |
| Nov 17 2023, 12:34 AM |
| F41483600: image.png | |
| Nov 10 2023, 4:47 PM |
The temp user popup is implemented in mediawiki.action.view.postEdit.js, but is likely to be needed by more workflows than editing (see parent task).
We should make it a reusable component.
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | https://phabricator.wikimedia.org/T349220 here |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Create module for showing a popup when a temporary user is created | mediawiki/core | master | +62 -41 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Restricted Task | |||||
| Resolved | kostajh | T294511 2021 Security Team wikireplicas audit | |||
| Declined | None | T284948 Raw IPs of logged-out users disclosed in wiki-replicas | |||
| Resolved | Niharika | T324492 Temporary accounts - MVP | |||
| Resolved | kostajh | T349129 [Epic] Workflows that create an IP (anon) actor should create a temporary user actor instead | |||
| Resolved | Tchanders | T349220 [M] Re-implement temp user created popup somewhere reusable |
Change 972437 had a related patch set uploaded (by Tchanders; author: Tchanders):
[mediawiki/core@master] Create module for showing a popup when a temporary user is created
Change 972437 merged by jenkins-bot:
[mediawiki/core@master] Create module for showing a popup when a temporary user is created
Testing notes
This shouldn't change the current functionality, and should only need regression testing.
Environment:
Steps:
@Tchanders Temp account pops up after you save an edit when you are logged out. The only thing is the wording is different from the screenshot above and what I got in de beta. Which is the correct one?
Status: ❓NMI
Environment: Beta: 1.42.0-alpha (3d1fbaa)
OS: macOS Sonoma 14.0
Browser: Chrome 119, Firefox 119, Safari 17.0
Skins. Vector 2022
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://de.wikipedia.beta.wmflabs.org/w/index.php?title=Black_Ice_(Album)&stable=0&shownotice=1
❓AC1: https://phabricator.wikimedia.org/T349220
Good
@GMikesell-WMF I think the version you're seeing might be the browser's translation of the German message inside the popup. If I ask my browser to translate de.wikipedia.beta for me, I get the same message. But if I visit https://de.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Postedit-temp-created/en I see what the actual English message would be.
@Tchanders Great, thanks for the information! Otherwise, I didn't come across anything else with the functionality not working as designed. I will move this to Done. Thanks for all your work!
Status: ✅ PASS
Environment: Beta: 1.42.0-alpha (2bb72a1)
OS: macOS Sonoma 14.0
Browser: Chrome 119
Skins. de beta
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://de.wikipedia.beta.wmflabs.org/w/index.php?title=Black_Ice_(Album)&stable=0&shownotice=1
✅AC1: https://phabricator.wikimedia.org/T349220
 |  |
