The readability survey tool (T349232) can be removed when we have 250 answers.
TODO
- Remove code from Vector
- Cleanup database of preferences relating to showing preview tool.
QA steps
Can skip QA.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove readability survey tool | operations/mediawiki-config | master | +0 -55 | |
| Remove typography survey | mediawiki/skins/Vector | master | +2 -381 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | BUG REPORT | ovasileva | T349232 Readability survey should link to language-specific feedback form | ||
| Resolved | Jdrewniak | T349337 Remove community readability survey tool code from production |
Event Timeline
Comment Actions
Change 980063 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):
[operations/mediawiki-config@master] Remove readability survey tool
Comment Actions
Change 980074 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):
[mediawiki/skins/Vector@master] Remove typography survey
Comment Actions
Change 980074 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Remove typography survey
Comment Actions
@Jdrewniak have we scheduled time to run the database cleanup maintenance script (or is this done already)?
Comment Actions
@Ladsgroup Happy new year! We removed the preference vector-typography-survey in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/980074/2/skin.json meaning any rows in the database relating to that preference can be reoved.
Will these automatically get purged from the preferences database or is this something we need to run manually? I can't seem to find any relevant documentation or maintenance script so sorry if this is a newbie question. It's not something I've done before.
Comment Actions
Hi and happy new year to you too! There is a maint script that can remove it (in core called cleanupPreferences.php) but unfortunately it doesn't allow dropping one specific user property, it just goes around and "cleans" everything it can't find in the code but that's a bit brittle. I'd really appreciate if you add support for dropping of a specific user option there which will come handy a lot.
A couple of random notes:
- This table is canonical data and once lost, it's gone forever. So take a lot of caution, we take a backup of the database weekly, so maybe start it in Tuesday.
- Start with beta cluster, then testwikis, then all wikis.
- We haven't run that script for really long time in prod, so it might be broken. Thankfully its logic is rather straightforward.
Let me know if/when/how I can help in every step of the work.
Comment Actions
userOptions.php has a --delete option
UserOptionsManager lets unknown option untouched, you can only reset the option in a hook when it gets loaded from the database (LoadUserOptions?). It should go away on next save.
T300371: Drop now unused user preferences from production database(s)
Comment Actions
I've verified that the command works locally.
- checking out an older release git fetch --all && git checkout wmf/1.41.0-wmf.30
- Logging in & setting the option to true new mw.Api().saveOptions({'vector-typography-survey': 1 });
- Access the docker container
- run php maintenance/run.php userOptions --wiki=my_wiki --delete --dry vector-typography-survey
output: Would delete 1 rows.
The script needs to be run on the following production wikis, since these were the only ones that we enabled the prototype on:
zhwiki fawiki kowiki jawiki hewiki frwiki viwiki ruwiki kawiki sewiki srwiki urwiki arwiki plwiki enwiki
Next step is to run the command on beta, then on prod. Not sure how to run the command on only these wikis does the --wiki option accept an array of strings? I can run the command individually for each wiki though.
beta command: mwscript userOptions.php foreachwikiindblist labs-all --delete --dry vector-typography-survey (then again without --dry)
Comment Actions
Not sure how to run the command on only these wikis does the --wiki option accept an array of strings?
Nope, do:
cat wikis_list | xargs -I{} mwscript userOptions --wiki={} --delete --dry vector-typography-surveyor something like that
the beta command should be this instead:
foreachwikiindblist labs-all userOptions.php --delete --dry vector-typography-survey
Comment Actions
ok great, I did a dry-run on labs and it looks like that'll be a no-op:
jdrewniak@deployment-deploy03:~$ foreachwikiindblist all-labs userOptions.php --delete --dry vector-typography-survey ----------------------------------------------------------------- aawiki ----------------------------------------------------------------- aawiki: Would delete 0 rows. ----------------------------------------------------------------- apiportalwiki ----------------------------------------------------------------- apiportalwiki: Would delete 0 rows. ----------------------------------------------------------------- arwiki ----------------------------------------------------------------- arwiki: Would delete 0 rows. ----------------------------------------------------------------- bnwiki ----------------------------------------------------------------- bnwiki: Would delete 0 rows. ----------------------------------------------------------------- cawiki ----------------------------------------------------------------- cawiki: Would delete 0 rows. ----------------------------------------------------------------- commonswiki ----------------------------------------------------------------- commonswiki: Would delete 0 rows. ----------------------------------------------------------------- crhwiki ----------------------------------------------------------------- crhwiki: Would delete 0 rows. ----------------------------------------------------------------- cswiki ----------------------------------------------------------------- cswiki: Would delete 0 rows. ----------------------------------------------------------------- dewiki ----------------------------------------------------------------- dewiki: Would delete 0 rows. ----------------------------------------------------------------- dewiktionary ----------------------------------------------------------------- dewiktionary: Would delete 0 rows. ----------------------------------------------------------------- en_rtlwiki ----------------------------------------------------------------- en_rtlwiki: Would delete 0 rows. ----------------------------------------------------------------- enwiki ----------------------------------------------------------------- enwiki: Would delete 0 rows. ----------------------------------------------------------------- enwikibooks ----------------------------------------------------------------- enwikibooks: Would delete 0 rows. ----------------------------------------------------------------- enwikinews ----------------------------------------------------------------- enwikinews: Would delete 0 rows. ----------------------------------------------------------------- enwikiquote ----------------------------------------------------------------- enwikiquote: Would delete 0 rows. ----------------------------------------------------------------- enwikisource ----------------------------------------------------------------- enwikisource: Would delete 0 rows. ----------------------------------------------------------------- enwikiversity ----------------------------------------------------------------- enwikiversity: Would delete 0 rows. ----------------------------------------------------------------- enwikivoyage ----------------------------------------------------------------- enwikivoyage: Would delete 0 rows. ----------------------------------------------------------------- enwiktionary ----------------------------------------------------------------- enwiktionary: Would delete 0 rows. ----------------------------------------------------------------- eowiki ----------------------------------------------------------------- eowiki: Would delete 0 rows. ----------------------------------------------------------------- eswiki ----------------------------------------------------------------- eswiki: Would delete 0 rows. ----------------------------------------------------------------- eswikibooks ----------------------------------------------------------------- eswikibooks: Would delete 0 rows. ----------------------------------------------------------------- fawiki ----------------------------------------------------------------- fawiki: Would delete 0 rows. ----------------------------------------------------------------- foundationwiki ----------------------------------------------------------------- foundationwiki: Would delete 0 rows. ----------------------------------------------------------------- hewiki ----------------------------------------------------------------- hewiki: Would delete 0 rows. ----------------------------------------------------------------- hewiktionary ----------------------------------------------------------------- hewiktionary: Would delete 0 rows. ----------------------------------------------------------------- hiwiki ----------------------------------------------------------------- hiwiki: Would delete 0 rows. ----------------------------------------------------------------- incubatorwiki ----------------------------------------------------------------- incubatorwiki: Would delete 0 rows. ----------------------------------------------------------------- jawiki ----------------------------------------------------------------- jawiki: Would delete 0 rows. ----------------------------------------------------------------- kowiki ----------------------------------------------------------------- kowiki: Would delete 0 rows. ----------------------------------------------------------------- loginwiki ----------------------------------------------------------------- loginwiki: Would delete 0 rows. ----------------------------------------------------------------- metawiki ----------------------------------------------------------------- metawiki: Would delete 0 rows. ----------------------------------------------------------------- nlwiki ----------------------------------------------------------------- nlwiki: Would delete 0 rows. ----------------------------------------------------------------- ruwiki ----------------------------------------------------------------- ruwiki: Would delete 0 rows. ----------------------------------------------------------------- simplewiki ----------------------------------------------------------------- simplewiki: Would delete 0 rows. ----------------------------------------------------------------- sqwiki ----------------------------------------------------------------- sqwiki: Would delete 0 rows. ----------------------------------------------------------------- srwiki ----------------------------------------------------------------- srwiki: Would delete 0 rows. ----------------------------------------------------------------- svwiki ----------------------------------------------------------------- svwiki: Would delete 0 rows. ----------------------------------------------------------------- testwiki ----------------------------------------------------------------- testwiki: Would delete 0 rows. ----------------------------------------------------------------- ukwiki ----------------------------------------------------------------- ukwiki: Would delete 0 rows. ----------------------------------------------------------------- viwiki ----------------------------------------------------------------- viwiki: Would delete 0 rows. ----------------------------------------------------------------- votewiki ----------------------------------------------------------------- votewiki: Would delete 0 rows. ----------------------------------------------------------------- wikidatawiki ----------------------------------------------------------------- wikidatawiki: Would delete 0 rows. ----------------------------------------------------------------- wikifunctionswiki ----------------------------------------------------------------- wikifunctionswiki: Would delete 0 rows. ----------------------------------------------------------------- zhwiki ----------------------------------------------------------------- zhwiki: Would delete 0 rows. ----------------------------------------------------------------- zhwikivoyage ----------------------------------------------------------------- zhwikivoyage: Would delete 0 rows.
So I'll run this command on prod after the afternoon backport window today, on mwmaint2002:
cat /jdrewniak/vector-typography-survey-wikis | xargs -I{} mwscript userOptions --wiki={} --delete --dry vector-typography-surveyComment Actions
oky, ran the script and it looks like the site is still up :P
jdrewniak@mwmaint2002:~$ cat /home/jdrewniak/vector-typography-survey-wikis | xargs -I{} mwscript userOptions --wiki={} --delete --dry vector-typography-survey
Would delete 92 rows.
Would delete 162 rows.
Would delete 0 rows.
Would delete 147 rows.
Would delete 118 rows.
Would delete 173 rows.
Would delete 94 rows.
Would delete 715 rows.
Would delete 27 rows.
Would delete 0 rows.
Would delete 1 rows.
Would delete 0 rows.
Would delete 172 rows.
Would delete 230 rows.
Would delete 630 rows.
jdrewniak@mwmaint2002:~$ cat /home/jdrewniak/vector-typography-survey-wikis | xargs -I{} mwscript userOptions --wiki={} --delete vector-typography-survey
The script is about to delete 'vector-typography-survey' option for ALL USERS from user_properties table.
This action is IRREVERSIBLE.
Abort with control-c in the next five seconds....0
Done! Deleted 92 rows.
The script is about to delete 'vector-typography-survey' option for ALL USERS from user_properties table.
This action is IRREVERSIBLE.
Abort with control-c in the next five seconds....0
Done! Deleted 162 rows.
The script is about to delete 'vector-typography-survey' option for ALL USERS from user_properties table.
This action is IRREVERSIBLE.
Abort with control-c in the next five seconds....0
Done! Deleted 0 rows.
The script is about to delete 'vector-typography-survey' option for ALL USERS from user_properties table.
This action is IRREVERSIBLE.
Abort with control-c in the next five seconds....0
Done! Deleted 147 rows.
The script is about to delete 'vector-typography-survey' option for ALL USERS from user_properties table.
This action is IRREVERSIBLE.
Abort with control-c in the next five seconds....0
Done! Deleted 118 rows.
The script is about to delete 'vector-typography-survey' option for ALL USERS from user_properties table.
This action is IRREVERSIBLE.
Abort with control-c in the next five seconds....0
Done! Deleted 173 rows.
The script is about to delete 'vector-typography-survey' option for ALL USERS from user_properties table.
This action is IRREVERSIBLE.
Abort with control-c in the next five seconds....0
Done! Deleted 94 rows.
The script is about to delete 'vector-typography-survey' option for ALL USERS from user_properties table.
This action is IRREVERSIBLE.
Abort with control-c in the next five seconds....0
Done! Deleted 715 rows.
The script is about to delete 'vector-typography-survey' option for ALL USERS from user_properties table.
This action is IRREVERSIBLE.
Abort with control-c in the next five seconds....0
Done! Deleted 27 rows.
The script is about to delete 'vector-typography-survey' option for ALL USERS from user_properties table.
This action is IRREVERSIBLE.
Abort with control-c in the next five seconds....0
Done! Deleted 0 rows.
The script is about to delete 'vector-typography-survey' option for ALL USERS from user_properties table.
This action is IRREVERSIBLE.
Abort with control-c in the next five seconds....0
Done! Deleted 1 rows.
The script is about to delete 'vector-typography-survey' option for ALL USERS from user_properties table.
This action is IRREVERSIBLE.
Abort with control-c in the next five seconds....0
Done! Deleted 0 rows.
The script is about to delete 'vector-typography-survey' option for ALL USERS from user_properties table.
This action is IRREVERSIBLE.
Abort with control-c in the next five seconds....0
Done! Deleted 172 rows.
The script is about to delete 'vector-typography-survey' option for ALL USERS from user_properties table.
This action is IRREVERSIBLE.
Abort with control-c in the next five seconds....0
Done! Deleted 230 rows.
The script is about to delete 'vector-typography-survey' option for ALL USERS from user_properties table.
This action is IRREVERSIBLE.
Abort with control-c in the next five seconds....0
Done! Deleted 630 rows.Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-01-11T21:36:30Z] <jan_drewniak> https://phabricator.wikimedia.org/T349337#9454773 running maintenance script to delete unnecessary user preferences.
Comment Actions
Change #980063 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove readability survey tool
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-05-20T20:25:27Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:980063|Remove readability survey tool (T349337)]], [[gerrit:1034149|wgVectorShareUserScripts should be false now (T301212)]]
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-05-20T20:28:03Z] <urbanecm@deploy1002> ksarabia and jdlrobson and urbanecm: Backport for [[gerrit:980063|Remove readability survey tool (T349337)]], [[gerrit:1034149|wgVectorShareUserScripts should be false now (T301212)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-05-20T20:44:01Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:980063|Remove readability survey tool (T349337)]], [[gerrit:1034149|wgVectorShareUserScripts should be false now (T301212)]] (duration: 18m 34s)