Page MenuHomePhabricator

MathRestbaseInterface: PHP Notice: Trying to get property '[property]' of non-object
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   PHP Notice: Trying to get property 'checked' of non-object
error.stack_trace
from /srv/mediawiki/php-1.42.0-wmf.1/extensions/Math/src/MathRestbaseInterface.php(377)
#0 /srv/mediawiki/php-1.42.0-wmf.1/extensions/Math/src/MathRestbaseInterface.php(377): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.42.0-wmf.1/extensions/Math/src/MathRestbaseInterface.php(140): MediaWiki\Extension\Math\MathRestbaseInterface->evaluateRestbaseCheckResponse(array)
#2 /srv/mediawiki/php-1.42.0-wmf.1/extensions/Math/src/MathRestbaseInterface.php(309): MediaWiki\Extension\Math\MathRestbaseInterface->checkTeX()
#3 /srv/mediawiki/php-1.42.0-wmf.1/extensions/Math/src/InputCheck/RestbaseChecker.php(40): MediaWiki\Extension\Math\MathRestbaseInterface->getSuccess()
#4 /srv/mediawiki/php-1.42.0-wmf.1/extensions/Math/src/MathRenderer.php(692): MediaWiki\Extension\Math\InputCheck\RestbaseChecker->isValid()
#5 /srv/mediawiki/php-1.42.0-wmf.1/extensions/Math/src/MathRenderer.php(603): MediaWiki\Extension\Math\MathRenderer->doCheck()
#6 /srv/mediawiki/php-1.42.0-wmf.1/extensions/Math/src/HookHandlers/ParserHooksHandler.php(118): MediaWiki\Extension\Math\MathRenderer->checkTeX()
#7 /srv/mediawiki/php-1.42.0-wmf.1/extensions/Math/src/HookHandlers/ParserHooksHandler.php(161): MediaWiki\Extension\Math\HookHandlers\ParserHooksHandler->mathPostTagHook(MediaWiki\Extension\Math\MathMathML, Parser)
#8 /srv/mediawiki/php-1.42.0-wmf.1/includes/HookContainer/HookContainer.php(161): MediaWiki\Extension\Math\HookHandlers\ParserHooksHandler->onParserAfterTidy(Parser, string)
#9 /srv/mediawiki/php-1.42.0-wmf.1/includes/HookContainer/HookRunner.php(2903): MediaWiki\HookContainer\HookContainer->run(string, array)
#10 /srv/mediawiki/php-1.42.0-wmf.1/includes/parser/Parser.php(1690): MediaWiki\HookContainer\HookRunner->onParserAfterTidy(Parser, string)
#11 /srv/mediawiki/php-1.42.0-wmf.1/includes/parser/Parser.php(654): Parser->internalParseHalfParsed(string, boolean, boolean)
#12 /srv/mediawiki/php-1.42.0-wmf.1/includes/language/MessageCache.php(1505): Parser->parse(string, MediaWiki\Title\Title, ParserOptions, boolean)
#13 /srv/mediawiki/php-1.42.0-wmf.1/includes/language/Message.php(1436): MessageCache->parse(string, MediaWiki\Title\Title, boolean, boolean, Language)
#14 /srv/mediawiki/php-1.42.0-wmf.1/includes/language/Message.php(1006): Message->parseText(string)
#15 /srv/mediawiki/php-1.42.0-wmf.1/includes/language/Message.php(1046): Message->format(string)
#16 /srv/mediawiki/php-1.42.0-wmf.1/includes/skins/Skin.php(833): Message->parse()
#17 /srv/mediawiki/php-1.42.0-wmf.1/includes/skins/SkinMustache.php(119): Skin->printSource()
#18 /srv/mediawiki/php-1.42.0-wmf.1/skins/Vector/includes/SkinVector22.php(346): SkinMustache->getTemplateData()
#19 /srv/mediawiki/php-1.42.0-wmf.1/includes/skins/SkinMustache.php(92): MediaWiki\Skins\Vector\SkinVector22->getTemplateData()
#20 /srv/mediawiki/php-1.42.0-wmf.1/includes/skins/SkinTemplate.php(174): SkinMustache->generateHTML()
#21 /srv/mediawiki/php-1.42.0-wmf.1/includes/Output/OutputPage.php(2937): SkinTemplate->outputPage()
#22 /srv/mediawiki/php-1.42.0-wmf.1/includes/exception/MWExceptionRenderer.php(188): MediaWiki\Output\OutputPage->output()
#23 /srv/mediawiki/php-1.42.0-wmf.1/includes/exception/MWExceptionRenderer.php(105): MWExceptionRenderer::reportHTML(Error)
#24 /srv/mediawiki/php-1.42.0-wmf.1/includes/exception/MWExceptionHandler.php(134): MWExceptionRenderer::output(Error, integer)
#25 /srv/mediawiki/php-1.42.0-wmf.1/includes/exception/MWExceptionHandler.php(251): MWExceptionHandler::report(Error)
#26 /srv/mediawiki/php-1.42.0-wmf.1/includes/MediaWiki.php(635): MWExceptionHandler::handleException(Error, string)
#27 /srv/mediawiki/php-1.42.0-wmf.1/index.php(50): MediaWiki->run()
#28 /srv/mediawiki/php-1.42.0-wmf.1/index.php(46): wfIndexMain()
#29 /srv/mediawiki/w/index.php(3): require(string)
#30 {main}
Impact

Unclear.

Notes

Getting this with properties checked, identifiers, success.

This seems to be longstanding at a low rate, at least since 1.41.0-wmf.27 and probably earlier.

Larger spikes are apparent since 2023-10-19, but it's not clear that has anything to do with 1.42.0-wmf.1 (T348354).

Details

Request URL
https://nl.wikipedia.org/w/index.php?diff=*&oldid=*&title=*
Related Changes in Gerrit:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
brennen renamed this task from PHP Notice: Trying to get property '[property]' of non-object to MathRestbaseInterface: PHP Notice: Trying to get property '[property]' of non-object.Oct 20 2023, 3:58 PM
brennen updated the task description. (Show Details)
brennen added a project: Editing-team.

Change 969429 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@master] Identify errorous restBASE responses

https://gerrit.wikimedia.org/r/969429

Change 969429 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Identify errorous restBASE responses

https://gerrit.wikimedia.org/r/969429

I expect that this is fixed now.

Was already fixed in last weeks release it seems:
Probably turned into another message

Screenshot 2023-11-07 at 15.33.44.png (729×565 px, 52 KB)

Found it. This turned into:

body: upstream connect error or disconnect/reset before headers. reset reason: connection failure
channel: Math
code: 503
message: Received invalid response from restbase.

https://logstash.wikimedia.org/goto/1bdf3a8631cfcbf2c48cf6f14a04ba78

Screenshot 2023-11-07 at 15.48.09.png (1,264×626 px, 83 KB)

So I think upstream connect error or disconnect/reset before headers. reset reason: connection failure is now properly logged. Unfortunately we still don't know which server the response is from.

I guess that is not in the body. Probably in a response header ??
https://logstash.wikimedia.org/goto/1ce4157c2634a2bd491e052b260aae3e