Page MenuHomePhabricator

AFTv5 Feedback form Option 3 Ratings do not work on IE7
Closed, DeclinedPublic

Description

AFT IE7 Bug - Option 3

When I click on the star icons to rate an article on IE7, the icons do not change color. I can see the labels below change, but I cannot see the star ratings.

The star ratings should become orange when I click on them.

See attached screenshot.

Found on Windows IE7 on my Dell Latitude laptop, using IE7 7.05730 over XP for Windows XP Professional 2002.


Version: unspecified
Severity: blocker
OS: Windows XP
Platform: PC

Attached:

AFT5-IE7-Test-Option3-Bug.JPG (768×1 px, 113 KB)

Details

Reference
bz32939
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Integrate 2 new features from upstreamrepos/sre/kafkakit-prometheus-metricsfetcher!3brouberolupdate-upstreammain
Customize query in GitLab

Related Objects

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 11:59 PM
bzimport set Reference to bz32939.

This is still a problem on IE7, even after Monday's push.

I cannot click on the ratings at all.

Also, the trash icon should be removed for all platforms (it still wraps around to the next line on Safari, and is not really needed)

Thanks,

-f

yoni wrote:

if we remove the trash icon, how can the ratings be reset?

It's possible to simply refresh the page to empty your rating, but it is true that users may not know how to do that.

For now, you are welcome to keep the trash icon in, but then we would want to fix the Safari bug that makes it wrap around. Though that is not a show-stopper, and we could live with it for this launch, since it has very limited impact.

yoni wrote:

  1. Ratings don't work on IE7 - we cannot reproduce this issue.
  2. Trash icons wraps on Safari - we cannot reproduce this issue, tested with Safari on both 10.6 and 10.7.

The problem persists on my IE7 machine.

I am a lot more concerned with the IE7 issue than the Safari issue, which we can let slide.

On my machine, not only are the star ratings not being displayed or recorded, but the comments that I type are not being stored either, according to the feedback page.

The last three posts I entered with this form on IE7 are ignoring both the ratings and the comments which I entered, as shown below.

Feedback #319, at 20111213213735
Fabrice Florin rated this page /5
Option 3 | Hide this (0) | Flag as abuse (0)

Feedback #318, at 20111213213608
98.210.230.160 rated this page /5
Option 3 | Hide this (0) | Flag as abuse (0)

Feedback #317, at 20111213213413
98.210.230.160 rated this page /5
Option 3 | Hide this (0) | Flag as abuse (0)

Hi Yoni,

Howie is experiencing the same problem on his completely different IE7 machine.

So I conclude that the problem is very real and we must solve it for launch.

Our best option now would be to disable this form for IE7, unless you have a better idea that can be done in the next few hours.

Is it possible to have a different bucketing system for IE7, with only two options? (1 and 2)

Or do you have a better recommendation?

Let's discuss by phone, then follow up on this thread, so we are all on the same page.

For now, I have reassigned this show-stopper ticket to you.

yoni wrote:

I just verified that this is just a visual bug. Rating are being saved correctly to the database.
They are not visible on the feedback page, which is being developed for the next phase, and is being disabled for this release.

Good news.

Hopefully we can fix the visual issue in coming days, even though this is no longer a 1.0 launch item.

I have changed this ticket's phase keyword to aftv5-1.5 for now.

Lowering priority. Please see [[mw:Bug management/Bugzilla usage]] for an overview of how we use priority. Additionally, for software that is not yet released (e.g. AFTv5), it is probably best to avoid the "highest" priority level.

Please contact me (mhershberger@wikimedia.org) if you have questions.

reha wrote:

Option 3 is no longer being tested.