Page MenuHomePhabricator
Create Task
Maniphest T34943

Auto-conversion between zh-hans & zh-hant in <syntaxhighlight> elements
Open, MediumPublicFeature
Actions

Description

Author: carivx

Description:
In zh-wiki, there are auto-conversion between zh-hans and zh-hant, but it's unavailable for the text (especially for the comment part) in <syntaxhighlight></syntaxhighlight>...

Version: unspecified
Severity: normal

The other problem is that line-wrapping is also unavailable for the text in <syntaxhighlight></syntaxhighlight>, maybe you can try
<syntaxhighlight>aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa</syntaxhighlight>
It's really crazy= =

Details

Reference
bz32943
ProjectBranchLines +/-Subject
mediawiki/extensions/SyntaxHighlight_GeSHimaster+85 -2Add language conversion support using LanguageConverter on syntaxhighlight
mediawiki/extensions/SyntaxHighlight_GeSHimaster+40 -0Apply LanguageConverter on some type of elements in syntaxhighlight tag
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:59 PM
• bzimport added a project: SyntaxHighlight.
• bzimport set Reference to bz32943.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Dec 10 2011, 5:54 AM
MarkAHershberger added a comment.Dec 14 2011, 4:18 AM

(In reply to comment #0)

The other problem is that line-wrapping is also unavailable for the text in
<source></source>, maybe you can try

This is expected behavior.

• bzimport added a comment.Dec 14 2011, 1:15 PM

carivx wrote:

(In reply to comment #1)

(In reply to comment #0)

The other problem is that line-wrapping is also unavailable for the text in
<source></source>, maybe you can try

This is expected behavior.

Er...That's right, I used a bad example= = I just mean line-wrapping is necessary when the comment is too long (usually seen in zhwiki),

MarkAHershberger added a comment.Dec 14 2011, 3:39 PM

(In reply to comment #2)

Er...That's right, I used a bad example= = I just mean line-wrapping is
necessary when the comment is too long (usually seen in zhwiki),

Even if there were spaces, you would see that this is expected behavior. This is how the underlying html treats <pre> tags. See for example: [[User:MarkAHershberger/Bug32943]].

If you just want comments to wrap, then that is a separate bug. Please open a new bug for that.

• bzimport added a comment.Dec 17 2011, 2:37 PM

carivx wrote:

(In reply to comment #3)

(In reply to comment #2)

Er...That's right, I used a bad example= = I just mean line-wrapping is
necessary when the comment is too long (usually seen in zhwiki),

Even if there were spaces, you would see that this is expected behavior. This
is how the underlying html treats <pre> tags. See for example:
[[User:MarkAHershberger/Bug32943]].

If you just want comments to wrap, then that is a separate bug. Please open a
new bug for that.

That's my fault= = And thank you for your notice; )
But I find that I cannot modify the description of this bug : ( Or can I divide it into 2 posts?

MarkAHershberger added a comment.Dec 21 2011, 2:23 AM

(In reply to comment #4)

(In reply to comment #3)

If you just want comments to wrap, then that is a separate bug. Please open a
new bug for that.

But I find that I cannot modify the description of this bug : ( Or can I divide
it into 2 posts?

Just create a new bug with the wrapping comments issue. That should take care of it.

jayvdb added a project: I18n.Dec 12 2015, 9:44 PM
jayvdb added a subscriber: jayvdb.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 12 2015, 9:44 PM
Shizhao added a subtask: T125033: [DO NOT USE] Chinese Wikimedia projects (tracking) [superseded by #Chinese-Sites].Jan 28 2016, 2:19 AM
Liuxinyu970226 removed a subtask: T125033: [DO NOT USE] Chinese Wikimedia projects (tracking) [superseded by #Chinese-Sites].Jan 28 2016, 4:01 AM
Liuxinyu970226 added a parent task: T125033: [DO NOT USE] Chinese Wikimedia projects (tracking) [superseded by #Chinese-Sites].
Arthur2e5 renamed this task from Auto-translation between zh-hans & zh-hant in <source> elements to Auto-conversion between zh-hans & zh-hant in <source> elements.EditedApr 12 2016, 12:49 AM
Arthur2e5 updated the task description. (Show Details)
Arthur2e5 added a subscriber: Arthur2e5.

It would be great to see conversions between zh variants in comments since zh.wp uses code examples for explanation extensively. So +1 to the bug...

It should be made optional though (<source zhconv="false">?)

Liuxinyu970226 added a subscriber: Liuxinyu970226.May 22 2016, 1:38 AM
Aklapper added a project: Chinese-Sites.Dec 21 2016, 9:59 AM
Aklapper removed a parent task: T125033: [DO NOT USE] Chinese Wikimedia projects (tracking) [superseded by #Chinese-Sites].Dec 21 2016, 10:03 AM
zhuyifei1999 moved this task from Backlog to Extensions/Skins on the Chinese-Sites board.Dec 21 2016, 8:08 PM
Liuxinyu970226 mentioned this in T170916: 希望source、展开模板及消息页面能够开启自动繁简转换.Jul 18 2017, 10:42 AM
zhuyifei1999 merged tasks: T170916: 希望source、展开模板及消息页面能够开启自动繁简转换, T160696: Provide a way of running language converter on syntaxhighlight-tagged code samples.Jul 18 2017, 11:19 AM
zhuyifei1999 added subscribers: SolidBlock, Nemo_bis, Stang, zhuyifei1999.
Arthur2e5 added a comment.EditedJul 18 2017, 1:54 PM

As for T170916, I personally don't believe that nowiki fails conversion. The pre part can be worked around with the good ol' -{}- hack mentioned in T160696 (and the docs in https://mediawiki.org/wiki/Writing_systems/Syntax#Exception). The rest of T170916 should not be merged, as it additionally requests auto conversion of MediaWiki: message pages. In fact, T170916 should be refined and reduced into just the MW messages and unmerged.

For highly subjective reasons, I am against the direction the T160696/T34943 merger is done due to the quality of the initial comment. But we can edit and manually merge that.

Arthur2e5 added a comment.Jul 18 2017, 1:55 PM
This comment was removed by Arthur2e5.
MarkAHershberger removed a subscriber: MarkAHershberger.Jul 18 2017, 7:48 PM
Shizhao added a subscriber: Shizhao.Jul 19 2017, 1:54 AM

It should be made optional though (<source zhconv="false">?)

good idea!

Amire80 moved this task from Untriaged to Script conversion on the I18n board.Feb 4 2018, 10:46 AM
Winston_Sung added a subscriber: Winston_Sung.Jul 7 2021, 7:20 PM
gerritbot added a comment.Feb 15 2022, 3:30 PM

Change 762760 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Add langconv argument for LanguageConverter on syntaxhighlight

https://gerrit.wikimedia.org/r/762760

gerritbot added a project: Patch-For-Review.Feb 15 2022, 3:30 PM
PatchDemoBot added a comment.Feb 15 2022, 4:07 PM

Test wiki created on Patch demo by Winston Sung using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/f81bf4e2d0/w/

PatchDemoBot added a comment.Feb 15 2022, 4:33 PM

Test wiki on Patch demo by Winston Sung using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/f81bf4e2d0/w/

PatchDemoBot added a comment.Feb 15 2022, 4:35 PM

Test wiki created on Patch demo by Winston Sung using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/701deeead6/w/

Winston_Sung changed the task status from Open to In Progress.Feb 15 2022, 4:36 PM
Winston_Sung claimed this task.
PatchDemoBot added a comment.Feb 15 2022, 4:47 PM

Test wiki created on Patch demo by Winston Sung using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/2d693b7302/w/

PatchDemoBot added a comment.Feb 15 2022, 4:53 PM

Test wiki on Patch demo by Winston Sung using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/2d693b7302/w/

PatchDemoBot added a comment.Feb 16 2022, 4:54 AM

Test wiki on Patch demo by Winston Sung using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/701deeead6/w/

PatchDemoBot added a comment.Feb 16 2022, 5:03 AM

Test wiki created on Patch demo by Winston Sung using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/6986bcd9ad/w/

PatchDemoBot added a comment.Feb 16 2022, 6:00 AM

Test wiki on Patch demo by Winston Sung using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/6986bcd9ad/w/

gerritbot added a comment.Feb 19 2022, 11:15 AM

Change 763740 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Apply LanguageConverter on some type of elements in syntaxhighlight tag

https://gerrit.wikimedia.org/r/763740

Func removed Winston_Sung as the assignee of this task.Feb 19 2022, 11:32 AM
Func added a subscriber: Func.

To be fair, don't claim this task now :)

gerritbot added a comment.Feb 19 2022, 12:32 PM

Change 762760 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Add language conversion support using LanguageConverter on syntaxhighlight

https://gerrit.wikimedia.org/r/762760

PatchDemoBot added a comment.Feb 19 2022, 12:54 PM

Test wiki created on Patch demo by Winston Sung using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/f39fb53fde/w/

PatchDemoBot added a comment.Feb 19 2022, 1:09 PM

Test wiki created on Patch demo by Winston Sung using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/6000f5e71f/w/

PatchDemoBot added a comment.Feb 19 2022, 2:02 PM

Test wiki on Patch demo by Winston Sung using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/6000f5e71f/w/

PatchDemoBot added a comment.Feb 19 2022, 2:04 PM

Test wiki created on Patch demo by Winston Sung using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/48f0b19eb2/w/

Func added a comment.Feb 19 2022, 2:11 PM

@Winston_Sung Please don't create patch demos frequently, or at least don't let it emit messages to the task. You can post a comment yourself and edit it once links are updated.

Winston_Sung added a comment.Feb 19 2022, 2:14 PM

Sorry for that.

Winston_Sung added a project: MediaWiki-Language-converter.Feb 19 2022, 4:34 PM
SunAfterRain renamed this task from Auto-conversion between zh-hans & zh-hant in <source> elements to Auto-conversion between zh-hans & zh-hant in <syntaxhighlight> elements.Feb 20 2022, 12:25 AM
PatchDemoBot added a comment.Feb 21 2022, 2:43 PM

Test wiki on Patch demo by Winston Sung using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/48f0b19eb2/w/

PatchDemoBot added a comment.May 22 2022, 4:31 PM

Test wiki on Patch demo by Winston Sung using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/f39fb53fde/w/

Restricted Application added a subscriber: Ericliu1912. · View Herald TranscriptMay 22 2022, 4:32 PM
Stang merged a task: T281024: CodeMirror: Support highlighting for language conversion tags -{}-.Jul 17 2022, 1:15 AM
Stang added subscribers: Diskdance, SunAfterRain.
Diskdance updated the task description. (Show Details)Jul 17 2022, 5:55 AM
Winston_Sung updated the task description. (Show Details)Oct 9 2022, 11:15 AM
Winston_Sung updated the task description. (Show Details)
Winston_Sung changed the task status from In Progress to Open.Feb 4 2023, 11:20 AM
Shizhao changed the subtype of this task from "Task" to "Feature Request".Feb 21 2023, 2:55 AM
Winston_Sung moved this task from Backlog to Extensions/Skins on the MediaWiki-Language-converter board.Sat, Mar 18, 4:13 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL