Page MenuHomePhabricator

MergeHistoryTest testSourceUpdateWithRedirectSupport doesn't test what it is supposed to
Closed, ResolvedPublic

Description

Due to the merge failing with an overlapping timestamps error as a result of trying to merge a page that was already merged by a previous test.

Discovered while writing tests for T183501 (I added some debug prints to the overlapping timestamps case to check why the test I wrote was getting that error, and noticed that this test was triggering this when it shouldn't)

Details

Related Changes in Gerrit:

Event Timeline

doesn't test what it is supposed to

So what should it test for and what is it testing now?

error as a result of trying to merge a page that was already merged by a previous test.

Maybe they should use different pages then

Change 975391 had a related patch set uploaded (by Pppery; author: Pppery):

[mediawiki/core@master] Fix testSourceUpdateWithRedirectSupport

https://gerrit.wikimedia.org/r/975391

Change 975391 merged by jenkins-bot:

[mediawiki/core@master] Fix testSourceUpdateWithRedirectSupport

https://gerrit.wikimedia.org/r/975391