Page MenuHomePhabricator

Merge claimmentee and setmentor filters in GrowthExperiments log
Closed, ResolvedPublic

Description

These are currently "Mentor changes" and "Mentee changes". Those sound like synonyms to me.

Copy suggestion: Mentor assignment changes.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Those sound like synonyms to me.

Could you elaborate please? In my understanding mentor is someone who provides training, mentee is someone who receives training...

Yes, but in context both actions are changing a mentor-mentee relationship, which both changes someone's mentor(s) and someone else's mentee(s).

Thank you @Pppery for reporting this! I agree we should make the messaging here less confusing. Wondering what's the best alternative though. Explanation of both filters:

  • claimmentee: used when a mentor uses Special:ClaimMentee to claim a mentee
  • setmentor: used when an admin uses the API to set someone's mentor to a different user

Maybe we can use something of the following:

  • claimmentee: Mentor-performed mentor changes / Claimed mentees
  • setmentor: Admin-performed mentor changes

but I don't really like this language either. Do you have any thoughts on this, @Pppery?

Urbanecm_WMF moved this task from Inbox to Backlog on the Growth-Team board.

Have you thought of combining them into one filter? Inability to clearly articulate the difference in the format of a log filter suggests it may not be as important to users as you think.

Aside from that, we should probably use the word "claim" somewhere in the description for claimmentee, but I'm having no better ideas.

Pppery renamed this task from Use better names for claimmentor and setmentor filters in GrowthExperiments log to Use better names for claimmentee and setmentor filters in GrowthExperiments log.Oct 25 2023, 9:52 PM

Good point @Pppery. Agreed, let's merge them!

Pppery renamed this task from Use better names for claimmentee and setmentor filters in GrowthExperiments log to Merge claimmentee and setmentor filters in GrowthExperiments log.Oct 29 2023, 6:13 PM
EMcFarland-WMF changed the task status from Open to In Progress.Nov 6 2025, 11:04 AM
EMcFarland-WMF claimed this task.

Change #1207868 had a related patch set uploaded (by EMcFarland; author: EMcFarland):

[mediawiki/extensions/GrowthExperiments@master] Merge claimmentee and setmentor filters in Growth Experiments events on Log Page

https://gerrit.wikimedia.org/r/1207868

Change #1207868 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Merge claimmentee and setmentor filters in Growth Experiments events on Log Page

https://gerrit.wikimedia.org/r/1207868

Urbanecm_WMF changed the task status from In Progress to Open.Nov 25 2025, 4:33 PM
Etonkovidova subscribed.

Checked the following logging actions on Special:Log?type=growthexperiments

+--------------------------------+
| log_action                     |
+--------------------------------+
| claimmentee                    |
| claimmentee-no-previous-mentor |
| setmentor                      |
| setmentor-no-previous-mentor   |
+--------------------------------+

All looks as expected.