Page MenuHomePhabricator

Vagrant: git-review fails on puppet/modules/nginx
Open, Needs TriagePublic

Description

On a fresh box, trying to review a Vagrant patch (from the host box):

$ git review

The following command failed with exit code 128
    "git submodule foreach cp -p .git/hooks/commit-msg "$(git rev-parse --git-dir)/hooks/""
-----------------------
Entering 'puppet/modules/nginx'
cp: cannot stat '.git/hooks/commit-msg': Not a directory
fatal: run_command returned non-zero status for puppet/modules/nginx
.
-----------------------

It got over it after I ran git-review -s but it's not great user experience. Maybe Puppet could run it automatically for new gerrit repos.