Page MenuHomePhabricator

<noinclude> renders incorrectly
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

{{#invoke:transcludable section|main|section=ledebio|text= and }} render as regular text around the content of the article.

What should have happened instead?: They should have been rendered as wikitext.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.): Wikipedia Beta 2.7.50455-beta-2023-10-10, Android 13
Appearance on Wikipedia Beta app

Screenshot_2023-10-25-10-11-33-993_org.wikipedia.beta.png (1×1 px, 331 KB)

Event Timeline

By checking the edit history, there was a wikitext added to the <ref></ref> tag, which may have a format error that caused this issue.
https://en.wikipedia.org/w/index.php?title=2023_Israel%E2%80%93Hamas_war&diff=prev&oldid=1181763009

Seddon triaged this task as Low priority.Nov 8 2023, 6:33 PM
Seddon moved this task from Needs Triage to Tracking on the Wikipedia-Android-App-Backlog board.

This edit broke it for Parsoid. It moved the </onlinclude> from *outside* the transclusion to *inside* the transclusion. So, Parsoid looked at the content within <onlyinclude> ... </onlyinclude> and found an unclosed transclusion and rendered it as text.

In the core parser, since it basically strips the onlyinclude tags no matter how it is nested, it is none the wiser.

Parsoid could be *smarter* about this, but this is a case of GIGO in my opinion and not something we are likely to priortize fixing any time soon (unless these kinds of errors are more common and we need to gracefully recover).

I think this task is also causing https://en.wikipedia.org/wiki/Wikipedia:Arbitration/Requests/Case to display with the raw template text in Parsoid, and it is very much not GIGO.