Page MenuHomePhabricator

Admins should be able to edit an active block without needing to delete it first
Open, HighPublic

Description

Background
Sometimes an admin may realize that their block is too prescriptive or needs to be adjusted. Instead of creating a new block and/or removing a block, they should be able to edit an active block.
recovered from original description
After T348682: List existing blocks on Special:Block, it could be useful to link directly to "edit" from the list of active blocks. Special:Block should be able to preload the block information by block id. Special:Block might need to change depending on whether we are reblocking a target by preloading all blocks from the target or changing a block by id (TBD based on UX)

Open Question

  • Internally reblocking an existing block is the same as editing a block and we need to clarify how we show that in the UI.
  • Do we need any limit as to how many blocks per user can exist?

Admins should be able to remove a block from a target user or IP range if the user has shown good behavior or if the block is no longer necessary.

Recovered from original description
After T348682: List existing blocks on Special:Block, it could be useful to link directly to unblock from the list of active blocks. Special:Unblock should be able to preload the block information by block id. Special:Unblock might need to change depending on wether we are unblocking a target (removing all active blocks) or removing a specific block

User Story
As an admin on the wikis, when I search for a user or IP on on Special:Block, then I should see a list of their active blocks, and I should have an easy way to remove blocks that are no longer necessary.

Benefits (why should this be implemented?):

Admins will need ways to remove a user's block.

h3. Acceptance Criteria:
A user must have admin rights to see the block search results
Typing in a valid IP address, range, or username should populate that target's blocks
The blocks should appear in a table
Hovering or clicking on the ellipses at the right of the table should show "edit" or "remove."
Selecting edit should populate a dialog where the user sees all the details and configurations for the block.
The admin can adjust any of the criteria for a block
By confirming, the block should be updated, visible in active blocks, and the block log should be updated.

Benefits (why should this be implemented?):
Easy access to edit a block/reblocking

Details for QA:
Admins should be able to edit a block when the list of active blocks is presented.

Designs:
https://www.figma.com/design/3PthdmimQ8FiuhGIsLhmZi/Multiblock?node-id=901-12893&t=w2MLTJPvCWbStpdt-0

Related Conversations:
https://meta.wikimedia.org/wiki/Talk:Community_Wishlist_Survey_2023/Multiblocks

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
ResolvedAug 21 2018dbarratt
DeclinedNone
OpenNone
Resolvedtstarling
Opentstarling
ResolvedHMonroy
Declineddmaza
StalledNone
OpenNone
ResolvedMusikAnimal
OpenNone
ResolvedLadsgroup
ResolvedPRODUCTION ERRORtstarling
Resolvedtstarling
Resolvedtstarling
Resolvedtstarling
ResolvedPRODUCTION ERRORtstarling
Opentstarling
ResolvedNone
Resolvedtstarling
OpenNone
OpenNone
ResolvedJWheeler-WMF

Event Timeline

This comment was removed by KSiebert.
dmaza renamed this task from Edit existing blocks on Special:Block to Edit active blocks from Special:Block.Nov 16 2023, 9:49 PM
dmaza updated the task description. (Show Details)

@dmaza From the Special: Block page if we're linking the user/Admin to the Block log to view active and past blocks, do we still need the above feature? I'm asking because the user/Admin can edit or remove block (currently called "change block" and "unblock") from the Block log.

JWheeler-WMF renamed this task from Edit active blocks from Special:Block to Admins should be able to edit an active block without needing to delete it first.Thu, May 23, 10:01 PM
JWheeler-WMF updated the task description. (Show Details)