Page MenuHomePhabricator
Create Task
Maniphest T349715

Show IPInfo infobox on Special:Contributions for temporary accounts
Closed, ResolvedPublic
Actions

Description

This task is for showing information for the last IP address used by the temp account on the Special:Contributions page

From the parent task:

The Contributions page for temporary users should show the IP Info accordion as it does on IP user pages.
Notes

  1. The information shown by default in the accordion should be of the IP that was used most recently.
  2. Include in the third column for IP Info:
    • Number of IPs that the temp account has used
    • A link to the special page for expanded view with all IPs (see above section)
    • An area for community tools

Accordion.png (525×1 px, 49 KB)

Acceptance criteria

  • Everything from the Notes
  • On-wiki information (contributions, blocks) is for the temporary account, not the IP address

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Look for log events when fetching temp user IPsmediawiki/extensions/IPInfomaster+220 -19
Extend InfoboxHandler testsmediawiki/extensions/IPInfomaster+157 -140
Show IPInfo infobox for temporary user contributionsmediawiki/extensions/IPInfomaster+283 -40
Support temporary users in LogHandlermediawiki/extensions/IPInfomaster+133 -43
Test IPInfo with CheckUserintegration/configmaster+1 -1
Support temporary users in revision-related handlersmediawiki/extensions/IPInfomaster+228 -51
Convert LogHandlerTest into a full integration testmediawiki/extensions/IPInfomaster+393 -591
Add integration test for ArchivedRevisionHandlermediawiki/extensions/IPInfomaster+681 -222
Add integration test for RevisionHandlermediawiki/extensions/IPInfomaster+789 -321
Support temporary users in IPoidInfoRetrievermediawiki/extensions/IPInfomaster+64 -8
Allow InfoManager to take either a UserIdentity or a stringmediawiki/extensions/IPInfomaster+55 -13
Introduce TempUserIPLookup servicemediawiki/extensions/IPInfomaster+414 -0
Introduce InfoRetriever to fetch unique IP address count for temp usersmediawiki/extensions/IPInfomaster+110 -0
Support temporary users in GeoIp2EnterpriseInfoRetrievermediawiki/extensions/IPInfomaster+80 -29
Support temporary users in GeoLite2InfoRetrievermediawiki/extensions/IPInfomaster+79 -21
Support temporary users in BlockInfoRetrievermediawiki/extensions/IPInfomaster+118 -30
Make ContributionInfoRetriever work for temporary usersmediawiki/extensions/IPInfomaster+152 -127
Convert InfoRetriever tests into unit testsmediawiki/extensions/IPInfomaster+92 -115
Pass a full UserIdentity to InfoRetrieversmediawiki/extensions/IPInfomaster+86 -43
Show IPInfo infobox on Special:Contributions for temporary accountsmediawiki/extensions/IPInfomaster+1 K -608
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Tchanders updated the task description. (Show Details)Oct 25 2023, 2:09 PM
Tchanders edited projects, added Trust and Safety Product Sprint; removed Trust and Safety Product Team.Nov 13 2023, 3:44 PM
Tchanders added a subtask: T325661: Add TemporaryAccountHandler API endpoint.Feb 7 2024, 2:55 PM
Tchanders edited parent tasks, added: T325662: Allow IPInfo's infobox widget to display data from more than one IP address; removed: T340895: [Epic] IP Info accommodations for temporary accounts.
Tchanders edited parent tasks, added: T340895: [Epic] IP Info accommodations for temporary accounts; removed: T325662: Allow IPInfo's infobox widget to display data from more than one IP address.Feb 9 2024, 11:33 AM
Tchanders added a subtask: T325662: Allow IPInfo's infobox widget to display data from more than one IP address.
Tchanders moved this task from Inbox to Create/update essential tools/anti-abuse management on the Temporary accounts board.Jun 4 2024, 3:21 PM
Tchanders edited projects, added Temporary accounts (Create/update essential tools/anti-abuse management); removed Temporary accounts.
kostajh mentioned this in T349534: Display IPInfo for a temporary account on a new SpecialPage.Jul 2 2024, 6:46 AM
Tchanders updated the task description. (Show Details)Jul 3 2024, 8:44 AM
Tchanders edited projects, added Temporary accounts (Blockers to minor pilot wiki deployment); removed Temporary accounts (Create/update essential tools/anti-abuse management).Jul 4 2024, 5:53 PM
• mszabo changed the task status from Open to In Progress.Jul 24 2024, 7:07 PM
• mszabo claimed this task.
• mszabo moved this task from Backlog to Sprint Koto (July 15 - July 26) on the Trust and Safety Product Sprint board.Jul 24 2024, 10:37 PM
• mszabo edited projects, added Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)); removed Trust and Safety Product Sprint.
• mszabo moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.
gerritbot added a comment.Jul 25 2024, 3:21 PM

Change #1056963 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Show IPInfo infobox on Special:Contributions for temporary accounts

https://gerrit.wikimedia.org/r/1056963

gerritbot added a project: Patch-For-Review.Jul 25 2024, 3:21 PM
• mszabo moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Jul 25 2024, 3:22 PM
gerritbot added a comment.Jul 25 2024, 11:31 PM

Change #1056963 abandoned by Máté Szabó:

[mediawiki/extensions/IPInfo@master] Show IPInfo infobox on Special:Contributions for temporary accounts

Reason:

This is too large to be reasonably reviewed, so I'll re-submit it as a series of smaller patches.

https://gerrit.wikimedia.org/r/1056963

Maintenance_bot removed a project: Patch-For-Review.Jul 26 2024, 12:30 AM
gerritbot added a comment.Jul 26 2024, 9:11 AM

Change #1057027 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Pass a full UserIdentity to InfoRetrievers

https://gerrit.wikimedia.org/r/1057027

gerritbot added a project: Patch-For-Review.Jul 26 2024, 9:11 AM

Change #1057030 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Convert InfoRetriever tests into unit tests

https://gerrit.wikimedia.org/r/1057030

gerritbot added a comment.Jul 26 2024, 9:15 AM

Change #1057032 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Make ContributionInfoRetriever work for temporary users

https://gerrit.wikimedia.org/r/1057032

gerritbot added a comment.Jul 26 2024, 9:16 AM

Change #1057035 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Support temporary users in BlockInfoRetriever

https://gerrit.wikimedia.org/r/1057035

gerritbot added a comment.Jul 29 2024, 4:44 PM

Change #1057027 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Pass a full UserIdentity to InfoRetrievers

https://gerrit.wikimedia.org/r/1057027

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.16; 2024-07-30).Jul 29 2024, 5:00 PM
gerritbot added a comment.Jul 30 2024, 11:32 AM

Change #1058124 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Introduce TempUserIPLookup service

https://gerrit.wikimedia.org/r/1058124

gerritbot added a comment.Jul 30 2024, 2:53 PM

Change #1058185 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Support temporary users in IPoidInfoRetriever

https://gerrit.wikimedia.org/r/1058185

gerritbot added a comment.Jul 30 2024, 3:03 PM

Change #1058190 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Support temporary users in GeoIp2EnterpriseInfoRetriever

https://gerrit.wikimedia.org/r/1058190

gerritbot added a comment.Jul 31 2024, 11:32 AM

Change #1058587 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Introduce InfoRetriever to fetch unique IP address count for temp users

https://gerrit.wikimedia.org/r/1058587

gerritbot added a comment.Jul 31 2024, 12:04 PM

Change #1058592 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Allow InfoManager to take either a UserIdentity or a string

https://gerrit.wikimedia.org/r/1058592

gerritbot added a comment.Jul 31 2024, 8:31 PM

Change #1057030 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Convert InfoRetriever tests into unit tests

https://gerrit.wikimedia.org/r/1057030

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.17; 2024-08-06); removed MW-1.43-notes (1.43.0-wmf.16; 2024-07-30).Jul 31 2024, 9:00 PM
gerritbot added a comment.Aug 1 2024, 12:02 PM

Change #1059049 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Convert RevisionHandlerTest into a full integration test

https://gerrit.wikimedia.org/r/1059049

gerritbot added a comment.Aug 1 2024, 1:39 PM

Change #1057032 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Make ContributionInfoRetriever work for temporary users

https://gerrit.wikimedia.org/r/1057032

gerritbot added a comment.Aug 1 2024, 1:44 PM

Change #1057035 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Support temporary users in BlockInfoRetriever

https://gerrit.wikimedia.org/r/1057035

gerritbot added a comment.Aug 1 2024, 1:50 PM

Change #1058124 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Introduce TempUserIPLookup service

https://gerrit.wikimedia.org/r/1058124

gerritbot added a comment.Aug 1 2024, 2:49 PM

Change #1059094 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Support temporary users in GeoLite2InfoRetriever

https://gerrit.wikimedia.org/r/1059094

gerritbot added a comment.Aug 1 2024, 3:53 PM

Change #1059094 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Support temporary users in GeoLite2InfoRetriever

https://gerrit.wikimedia.org/r/1059094

gerritbot added a comment.Aug 1 2024, 4:16 PM

Change #1058190 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Support temporary users in GeoIp2EnterpriseInfoRetriever

https://gerrit.wikimedia.org/r/1058190

gerritbot added a comment.Aug 1 2024, 4:52 PM

Change #1058587 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Introduce InfoRetriever to fetch unique IP address count for temp users

https://gerrit.wikimedia.org/r/1058587

gerritbot added a comment.Aug 2 2024, 11:24 AM

Change #1058592 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Allow InfoManager to take either a UserIdentity or a string

https://gerrit.wikimedia.org/r/1058592

Tchanders edited projects, added Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)); removed Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)).Aug 5 2024, 9:42 AM
Tchanders moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)) board.
jnuche mentioned this in T371966: Wikimedia\Assert\ParameterElementTypeException: Bad value for parameter info['data']: all elements must be MediaWiki\IPInfo\Info\Info|MediaWiki\IPInfo\Info\IPoidInfo|MediaWiki\IPInfo\Info\BlockInfo|MediaWiki\IPInfo\Info\Contrib.Aug 7 2024, 11:03 AM
gerritbot added a comment.Aug 13 2024, 1:33 PM

Change #1058185 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Support temporary users in IPoidInfoRetriever

https://gerrit.wikimedia.org/r/1058185

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.19; 2024-08-20); removed MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Aug 13 2024, 2:00 PM
gerritbot added a comment.Aug 16 2024, 10:34 AM

Change #1063172 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Add integration test for ArchivedRevisionHandler

https://gerrit.wikimedia.org/r/1063172

gerritbot added a comment.Aug 16 2024, 12:44 PM

Change #1059049 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Add integration test for RevisionHandler

https://gerrit.wikimedia.org/r/1059049

gerritbot added a comment.Aug 16 2024, 12:54 PM

Change #1063172 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Add integration test for ArchivedRevisionHandler

https://gerrit.wikimedia.org/r/1063172

Maintenance_bot removed a project: Patch-For-Review.Aug 16 2024, 1:30 PM
gerritbot added a comment.Aug 19 2024, 12:12 PM

Change #1063782 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Convert LogHandlerTest into a full integration test

https://gerrit.wikimedia.org/r/1063782

gerritbot added a project: Patch-For-Review.Aug 19 2024, 12:12 PM
gerritbot added a comment.Aug 19 2024, 1:21 PM

Change #1063807 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Support temporary users in revision-related handlers

https://gerrit.wikimedia.org/r/1063807

gerritbot added a comment.Aug 20 2024, 12:57 PM

Change #1064022 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Look for log events when fetching temp user IPs

https://gerrit.wikimedia.org/r/1064022

gerritbot added a comment.Aug 21 2024, 11:36 AM

Change #1064362 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Support temporary users in LogHandler

https://gerrit.wikimedia.org/r/1064362

gerritbot added a comment.Aug 21 2024, 12:17 PM

Change #1063782 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Convert LogHandlerTest into a full integration test

https://gerrit.wikimedia.org/r/1063782

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.20; 2024-08-27); removed MW-1.43-notes (1.43.0-wmf.19; 2024-08-20).Aug 21 2024, 1:00 PM
gerritbot added a comment.Aug 22 2024, 10:27 PM

Change #1064982 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Extend InfoboxHandler tests

https://gerrit.wikimedia.org/r/1064982

gerritbot added a comment.Aug 23 2024, 9:17 PM

Change #1063807 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Support temporary users in revision-related handlers

https://gerrit.wikimedia.org/r/1063807

gerritbot added a comment.Aug 26 2024, 1:42 PM

Change #1066775 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Show IPInfo infobox for temporary user contributions

https://gerrit.wikimedia.org/r/1066775

gerritbot added a comment.Aug 26 2024, 1:50 PM

Change #1066779 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[integration/config@master] Test IPInfo with CheckUser

https://gerrit.wikimedia.org/r/1066779

gerritbot added a comment.Aug 27 2024, 10:28 AM

Change #1066779 merged by jenkins-bot:

[integration/config@master] Test IPInfo with CheckUser

https://gerrit.wikimedia.org/r/1066779

gerritbot added a comment.Aug 27 2024, 12:20 PM

Change #1064022 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Look for log events when fetching temp user IPs

https://gerrit.wikimedia.org/r/1064022

gerritbot added a comment.Aug 27 2024, 12:20 PM

Change #1064362 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Support temporary users in LogHandler

https://gerrit.wikimedia.org/r/1064362

gerritbot added a comment.Aug 27 2024, 12:24 PM

Change #1064982 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Extend InfoboxHandler tests

https://gerrit.wikimedia.org/r/1064982

gerritbot added a comment.Aug 27 2024, 12:24 PM

Change #1066775 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Show IPInfo infobox for temporary user contributions

https://gerrit.wikimedia.org/r/1066775

Dreamy_Jazz moved this task from Sprint Erhu (August 5th - August 16th) to Sprint Theremin (Aug 26 - Sept. 6) on the Trust and Safety Product Sprint board.Aug 27 2024, 12:28 PM
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)); removed Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)).
Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.21; 2024-09-03); removed MW-1.43-notes (1.43.0-wmf.20; 2024-08-27).Aug 27 2024, 1:00 PM
kostajh moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.Aug 28 2024, 9:30 AM
dom_walden added a project: IP Info.Aug 28 2024, 9:57 AM
dom_walden mentioned this in T349716: Show IPInfo popup for temporary accounts.Aug 29 2024, 2:23 PM
kostajh moved this task from Backlog to In progress on the Temporary accounts (Blockers to minor pilot wiki deployment) board.Sep 15 2024, 5:04 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 15 2024, 5:30 PM
kostajh edited projects, added Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)); removed Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)).Sep 16 2024, 10:18 AM
Dreamy_Jazz moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.Sep 16 2024, 10:18 AM
Dreamy_Jazz moved this task from Needs QA to Priority Backlog on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.
Dreamy_Jazz moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.
kostajh moved this task from Backlog to In Progress on the IP Info board.Sep 17 2024, 9:46 AM
• mszabo mentioned this in T375185: Consider unifying temporary user IP lookup logic.Sep 19 2024, 12:16 PM
• mszabo edited projects, added Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)); removed Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)).Oct 8 2024, 10:06 AM
• mszabo moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)) board.
kostajh edited projects, added Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15); removed Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)).Oct 28 2024, 11:05 AM
kostajh moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.
kostajh moved this task from In progress to Done / QA on the Temporary accounts (Blockers to minor pilot wiki deployment) board.Oct 28 2024, 4:33 PM
dom_walden moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.Nov 5 2024, 9:44 AM
dom_walden subscribed.

I have looked at the infobox on Special:Contributions for temporary accounts and for IP addresses.

Incidentally, I have raised T379049 as I don't think that is being tracked anywhere.

Tchanders closed this task as Resolved.Nov 14 2024, 7:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits