Maniphest T349785

Use error type for invalid evaluation result
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DMartin-WMF
	Oct 26 2023, 1:17 AM

Tags

Referenced Files

None

Subscribers

Description

Description

There are several places in the orchestrator where we check for an invalid Z22 / Evaluation result. We are currently using Z547 / Invalid format for this error condition, but Z547 wasn't intended for this. Once the new error type is created for this purpose (by the child task), replace these uses of Z547 in the orchestrator with the new error type.

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Back-end_Task/Bug_completion_checklist

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	wikifunctions: Switch orchestrator to 2023-11-17-200241	operations/deployment-charts	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		DMartin-WMF	T321113 Audit and update creation and manipulation of errors in the orchestrator and evaluator
		Resolved		DMartin-WMF	T321114 Don't create generic errors in the orchestrator, but specific custom ones
		Resolved		DMartin-WMF	T349785 Use error type for invalid evaluation result
		Resolved		DMartin-WMF	T349784 Add error type for invalid evaluation result

Event Timeline

DMartin-WMF created this task.Oct 26 2023, 1:17 AM

DMartin-WMF added a subtask: T349784: Add error type for invalid evaluation result.

DMartin-WMF added a parent task: T321114: Don't create generic errors in the orchestrator, but specific custom ones.Oct 26 2023, 1:23 AM

Jdforrester-WMF triaged this task as Medium priority.Oct 26 2023, 4:43 PM

Jdforrester-WMF moved this task from To Triage to Backlog on the Abstract Wikipedia team board.

DMartin-WMF claimed this task.Nov 7 2023, 4:33 PM

DMartin-WMF closed subtask T349784: Add error type for invalid evaluation result as Resolved.

DMartin-WMF reopened subtask T349784: Add error type for invalid evaluation result as Open.Nov 7 2023, 4:36 PM

DMartin-WMF closed subtask T349784: Add error type for invalid evaluation result as Resolved.Nov 7 2023, 5:05 PM

DMartin-WMF mentioned this in T349784: Add error type for invalid evaluation result.

Jdforrester-WMF reopened subtask T349784: Add error type for invalid evaluation result as Open.Nov 14 2023, 8:38 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/89

Use invalid_evaluation_result instead of invalid_format

DMartin-WMF mentioned this in T287919: Audit ad Hoc Error Types in Orchestrator.Nov 16 2023, 5:59 AM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/89

Use invalid_evaluation_result instead of invalid_format

Maintenance_bot removed a project: Patch-For-Review.Nov 16 2023, 4:30 PM

Jdforrester-WMF changed the task status from Open to In Progress.Nov 16 2023, 5:23 PM

Jdforrester-WMF moved this task from Backlog to To deploy on the Abstract Wikipedia team board.

Jdforrester-WMF changed the status of subtask T349784: Add error type for invalid evaluation result from Open to In Progress.

Change 976848 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Switch orchestrator to 2023-11-17-200241

https://gerrit.wikimedia.org/r/976848

gerritbot added a project: Patch-For-Review.Nov 22 2023, 8:11 PM

Change 976848 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Switch orchestrator to 2023-11-17-200241

https://gerrit.wikimedia.org/r/976848

Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Nov 29 2023, 4:57 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 29 2023, 5:10 PM

Jdforrester-WMF closed subtask T349784: Add error type for invalid evaluation result as Resolved.Dec 4 2023, 7:12 PM

Jdforrester-WMF closed this task as Resolved.Dec 4 2023, 7:18 PM