Special:NewPagesFeed "new article appears in feed" test occasionally fails
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• matmarex
	Oct 26 2023, 7:03 PM

Project Tags

Referenced Files

None

Subscribers

Description

Special:NewPagesFeed "new article appears in feed" test occasionally fails. I've seen this two or three times this week.

Most recent: https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php74-docker/65872/console

Error in "Special:NewPagesFeed.new article appears in feed"
Error: expect(received).toContain(expected) // indexOf

Expected substring: "NewArticle-0.22096586190889655-Iñtërnâtiônàlizætiøn"
Received string:    "Showing:
State (Unreviewed), Type (All others)
Sort by:
Newest
Oldest
Set filters ▸
 Auto-refresh Refresh list"
    at Context.<anonymous> (/workspace/src/extensions/PageTriage/tests/selenium/specs/newpagesfeed.js:44:51)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	selenium: Wait until articles are loaded before querying article names	Sohom Datta	mediawiki/extensions/PageTriage	master	+7 -0

Customize query in gerrit

Related Objects

Mentioned Here: T349680: PageTriage selenium test flaky

Event Timeline

• matmarex created this task.Oct 26 2023, 7:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2023, 7:03 PM

Duplicate of T349680 ?

PageTriage is in the gate, so we should probably prioritize this ticket. Can disable the test or try to fix it.

My understanding is that this is a race condition, and the stringification of the UI is happening between the time the load occurs and the response of the fetch for the articles.

Change 969197 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] selenium: Wait until articles are loaded before querying article names

https://gerrit.wikimedia.org/r/969197

gerritbot added a project: Patch-For-Review.Oct 26 2023, 8:07 PM

jsn.sherman moved this task from Backlog to Waiting for enwiki deploy on the PageTriage board.Oct 27 2023, 4:35 PM

Change 969197 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] selenium: Wait until articles are loaded before querying article names

https://gerrit.wikimedia.org/r/969197

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.3; 2023-10-31).Oct 27 2023, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 27 2023, 5:10 PM

Thanks, hopefully that fixes it (and if anyone sees the error again, we can reopen).

Special:NewPagesFeed "new article appears in feed" test occasionally failsClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Special:NewPagesFeed "new article appears in feed" test occasionally fails
Closed, ResolvedPublic
Actions