Page MenuHomePhabricator
Create Task
Maniphest T349866

Subscribe link is misaligned
Closed, ResolvedPublicBUG REPORT
Actions

Description

When visiting a discussion page on a wiki without visual enhancements enabled, the [subscribe]/[unsubscribe] link added by DiscussionTools is misaligned within the heading, having drifted upwards from its original location. This is particularly noticable if [edit source] is visible, as that's displayed with a slight subscript.

e.g. https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(WMF)

image.png (150×1 px, 32 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix vertical position of [(un)subscribe] linksmediawiki/extensions/DiscussionToolsmaster+3 -1
Customize query in gerrit

Event Timeline

DLynch created this task.Oct 26 2023, 7:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2023, 7:37 PM
ppelberg moved this task from Untriaged to Upcoming on the Editing-team board.Oct 26 2023, 7:44 PM
ppelberg subscribed.
matmarex subscribed.Oct 29 2023, 5:56 PM

Oops, it's my fault from https://gerrit.wikimedia.org/r/c/mediawiki/core/+/857542.

Esanders subscribed.Oct 29 2023, 6:11 PM

Regression caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/857542 (cc @matmarex)

Esanders added a comment.Oct 29 2023, 6:11 PM

snap

gerritbot added a comment.Oct 30 2023, 4:04 PM

Change 969809 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Fix vertical position of [(un)subscribe] links

https://gerrit.wikimedia.org/r/969809

gerritbot added a project: Patch-For-Review.Oct 30 2023, 4:04 PM
Esanders claimed this task.Oct 30 2023, 4:04 PM
Esanders moved this task from Upcoming to Untriaged on the Editing-team board.
Esanders edited projects, added Editing-team (Kanban Board); removed Editing-team.
Esanders moved this task from Backlog to Triaged on the DiscussionTools board.
Esanders moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Oct 30 2023, 4:49 PM

Change 969809 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix vertical position of [(un)subscribe] links

https://gerrit.wikimedia.org/r/969809

DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Oct 30 2023, 4:56 PM
DLynch added a project: Editing QA.
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.3; 2023-10-31).Oct 30 2023, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 30 2023, 5:10 PM
EAkinloose edited projects, added Verified; removed Editing QA.Oct 30 2023, 8:57 PM
EAkinloose subscribed.

✅ Aligned with Topic Title as expected

Screenshot 2023-10-30 at 20.29.04.png (600×3 px, 301 KB)

Screenshot 2023-10-30 at 20.29.20.png (758×3 px, 361 KB)

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Oct 30 2023, 8:57 PM
ppelberg closed this task as Resolved.Oct 30 2023, 10:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits