Page MenuHomePhabricator

[S] Add some kind of logging when an actor is created with an IP address
Closed, ResolvedPublic

Description

We'd like to understand where IP actors can get created from. We should be careful not to overwhelm the logs.

First figure out:

  • What to log
  • How to log it
  • What proportion of the time to log (is 100% OK?)

Then implement the logging and agree a strategy for monitoring the data with @jwang.

Event Timeline

Change 969796 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] Log when an IP actor is created if temporary accounts are enabled

https://gerrit.wikimedia.org/r/969796

  • What to log

We need the IP address and the stack trace. Logging a warning to logstash with a bit of context should be enough.

  • How to log it

Via ActorStore::validateActorForInsertion should catch all cases where an actor is being made properly. We can do some direct searches for 'actor' to see if anyone is inserting not via ActorStore.

  • What proportion of the time to log (is 100% OK?)

For now, with temp accounts only being enabled on some beta wikis, this should be fine (the log only gets made if temp accounts are enabled).

Tchanders renamed this task from Add some kind of logging when an actor is created with an IP address to [S] Add some kind of logging when an actor is created with an IP address.Oct 30 2023, 4:21 PM

Change 969796 merged by jenkins-bot:

[mediawiki/core@master] Log when an IP actor is created if temporary accounts are enabled

https://gerrit.wikimedia.org/r/969796