Page MenuHomePhabricator

Two table of contents buttons: Issue with cached HTML introduced in 1.42.0-wmf.2
Closed, ResolvedPublicBUG REPORT

Description

NOTE: This bug is caused by cached HTML. It can be resolved by purging the page (using action=purge).

Steps to replicate the issue (include links if applicable):

What happens?:

  • When this bug occurs, there is an table of contents icon present to the left of the page's title. If the contents are hidden, there are two table of content icons, one is functional when clicked and the other is not.

What should have happened instead?:

  • If the contents are listed on the left, there should not be a table of contents icon to the left of the title. When the table of contents is hidden, there should be one table of contents icon to the left of the title that can be clicked on to display the table of contents.

ללא שם.png (378×252 px, 22 KB)

גרסה 118.0.5993.90.png (536×642 px, 44 KB)

Event Timeline

Jdlrobson added subscribers: ovasileva, Jdlrobson.

The page was cached. I cleared the cache and the issue has been fixed. This is more or less a duplicate of T349882 but I'm wondering if we need to do more than clear cache when we encounter this issue. It might be worth identifying how frequently this error state is occurring. What do you think @ovasileva ?

Jdlrobson renamed this task from Two table of contents buttons to Two table of contents buttons: Issue with cached HTML introduced in 1.42.0-wmf.12.Oct 30 2023, 4:29 PM
Jdlrobson renamed this task from Two table of contents buttons: Issue with cached HTML introduced in 1.42.0-wmf.12 to Two table of contents buttons: Issue with cached HTML introduced in 1.42.0-wmf.2.
Jdlrobson updated the task description. (Show Details)

The page was cached. I cleared the cache and the issue has been fixed. This is more or less a duplicate of T349882 but I'm wondering if we need to do more than clear cache when we encounter this issue. It might be worth identifying how frequently this error state is occurring. What do you think @ovasileva ?

That sounds good. Would it be possible to set up a ticket that takes care of the general case? Since we haven't received new reports here, I'm assuming the majority of pages have been updated by now.

I set up some error logging and saw 42,542 page views in the last 1hrs on English Wikipedia were impacted by this error.
https://logstash.wikimedia.org/goto/a776f085f1008ecdf42b4c602424bf40

@ovasileva only 8,342 page views in the last 1hr were impacted by the error. I think this should be resolved given the rate of the declining error rate.

ovasileva claimed this task.

@ovasileva only 8,342 page views in the last 1hr were impacted by the error. I think this should be resolved given the rate of the declining error rate.

Agreed. Resolving this.