Page MenuHomePhabricator

External links using {{fullurl:}} are saved twice into externallinks table
Open, MediumPublic

Description

When saving a page with new external link in form of e.g.:

[{{fullurl:tools:~danny_b|foo=bar}} My tools]

given link is saved twice in externallinks table.


Version: 1.18.x
Severity: major

Details

Reference
bz33010

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:04 AM
bzimport set Reference to bz33010.
bzimport added a subscriber: Unknown Object (MLST).

I believe its designed this way for protocol-relative urls, so both http:// and https:// exist in the table.

(In reply to comment #1)

I believe its designed this way for protocol-relative urls, so both http:// and
https:// exist in the table.

That's exactly right.

(add a note from irc about the four times thing)

[10:05] <p858snake|l> Danny_B|backup: I believe its needed for our protocol relative urls we use now, RoanKattouw will probably know more (if hes around at this hour)
[10:10] <Danny_B|backup> p858snake|l: well, the other thing is, that some are stored even 4 times
[10:11] <p858snake|l> you might want to add that to the bug with some examples

(In reply to comment #2)

(In reply to comment #1)

I believe its designed this way for protocol-relative urls, so both http:// and
https:// exist in the table.

That's exactly right.

However, two _same_ protocol relative links are stored.

So no for instance:
http://toolserver.org/~danny_b?foo=bar
https://toolserver.org/~danny_b?foo=bar

but twice
//toolserver.org/~danny_b?foo=bar

Ah, el_index is different, OK, I was checking el_to.

However problem described in comment 3 still applies. - Some URLs are stored 4 times (-> twice a pair of http/https).

I haven't find any dependency on any particular action yet though.