Page MenuHomePhabricator

Move Add Bookmark into Bookmarks, change bookmarks to "Saved Pages"
Closed, ResolvedPublic

Description

Author: philinje

Description:
Two things: we need to move Add Bookmark in order to free a spot in the menu, and we need to convey the new functionality of bookmarks as a form of saving pages for offline reading.

The submenu for Read Later will have the add function at the top, which will say:

Save this page

This will be the equivalent of "Add bookmark."

When saving this page, we should check to see if the page has already been saved, and if so, grey out the menu command, as covered in bug 33008.

If the cache for this is full or near full, we should warn the user that this page can be saved but the oldest saved page will be deleted (if that is in fact what will happen).


Version: 1.0.0 (Android)
Severity: enhancement

Details

Reference
bz33011

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:04 AM
bzimport set Reference to bz33011.
brion added a comment.Dec 15 2011, 6:19 PM

Reassigning to eager beaver yuvipanda :D

Bookmarks -> 'Saved pages' and
Add Bookmark -> 'Save page'

I don't think moving 'Save Page' into the 'Saved Pages' screen is a good idea - it should stay where it is right now. Can we close this, since everything else has landed?

Closing. Reopen if you think 'Save this Page' should go away from the menu.