Specify skin field in MobileWebUIActions
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	KSarabia-WMF
	Nov 1 2023, 12:03 AM

Project Tags

Referenced Files

	F41514335: Screenshot 2023-11-17 at 3.22.06 PM.png
	Nov 17 2023, 11:22 PM

	F41514331: Screenshot 2023-11-17 at 3.19.51 PM.png
	Nov 17 2023, 11:22 PM

Subscribers

Description

We need to specify the skin field even though Minerva Skin is default in the MobileWebUIActions schema for data collection purposes.

Additional Notes:
There are no validation errors and the skin value will always be Minerva. It's just for consistency, convenience and for cleaner tables.
This patch was created before this ticket.

TODO

Update the schema
Update Minerva to use the new schema version and send the skin field

QA

Verify that all events carry the skin field using the request SELECT event.skin, count(*) FROM event.mobilewebuiactionstracking WHERE year = 2023 AND event.action = 'init' AND ( month = 11 ) AND day = 17 AND wiki != 'testwiki' group by event.skin

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Updates schema version for mobilewebuiactions	Kimberly Sarabia	mediawiki/extensions/WikimediaEvents	master	+1 -1
	Adds skin field in mobilewebuiactions	Kimberly Sarabia	schemas/event/secondary	master	+267 -3

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	ovasileva	T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
Resolved	ovasileva	T341632 [EPIC] Palette customizations and dark mode
Resolved	jwang	T345001 Create instrumentation spec for establishing baseline for interface customization
Resolved	jwang	T346979 Report on baseline for interface customization
Resolved	Jdlrobson	T350205 Specify skin field in MobileWebUIActions

Event Timeline

KSarabia-WMF created this task.Nov 1 2023, 12:03 AM

Restricted Application added subscribers: Masumrezarock100, • Aklapper. · View Herald TranscriptNov 1 2023, 12:03 AM

Change 968674 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[schemas/event/secondary@master] Adds skin field in mobilewebuiactions

https://gerrit.wikimedia.org/r/968674

gerritbot added a project: Patch-For-Review.Nov 1 2023, 12:09 AM

KSarabia-WMF updated the task description. (Show Details)Nov 1 2023, 12:10 AM

ovasileva triaged this task as High priority.Nov 1 2023, 8:25 AM

ovasileva added a project: FY2023-24-WE 2.1 Typography and palette customizations.

ovasileva added a parent task: T346979: Report on baseline for interface customization.

Jdlrobson updated the task description. (Show Details)Nov 1 2023, 3:27 PM

Jdlrobson updated the task description. (Show Details)

Change 968675 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/extensions/WikimediaEvents@master] Updates schema version for mobilewebuiactions

https://gerrit.wikimedia.org/r/968675

KSarabia-WMF moved this task from Incoming to Code Review on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q2 Sprint 2) board.Nov 2 2023, 4:54 PM

After talking to Kim we've moved this to sprint 3 so we can estimate and provide appropriate amount of QA.

Jdlrobson set the point value for this task to 2.Nov 6 2023, 6:38 PM

Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q2 Sprint 3) board.Nov 6 2023, 6:59 PM

Change 968674 merged by jenkins-bot:

[schemas/event/secondary@master] Adds skin field in mobilewebuiactions

https://gerrit.wikimedia.org/r/968674

Change 968675 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Updates schema version for mobilewebuiactions

https://gerrit.wikimedia.org/r/968675

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 7 2023, 4:00 AM

Maintenance_bot removed a project: Patch-For-Review.Nov 7 2023, 4:10 AM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q2 Sprint 3) board.Nov 7 2023, 4:04 PM

Jdlrobson assigned this task to KSarabia-WMF.Nov 7 2023, 5:35 PM

QA Steps
In Hue, ensure that MobileWebUIActions has a skin column and is validating the skin value.
I can QA next week after this rides the train.

This will be testable tomorrow.

Jdlrobson updated the task description. (Show Details)Nov 17 2023, 11:19 PM

It looks like the majority of events have the skin field now. Presumably the others relate to open windows.

Screenshot 2023-11-17 at 3.19.51 PM.png (1,212×524 px, 52 KB)

I took a look at one of the null events using SELECT * FROM event.mobilewebuiactionstracking WHERE year = 2023 AND event.action = 'init' AND ( month = 11 ) AND day = 17 AND wiki != 'testwiki' AND event.skin is NULL limit 1 and all the new fields were also missing so was likely hitting an older schema.

Edtadros mentioned this in T350416: Verify 1.42.0-wmf.5 deployment.Nov 19 2023, 9:26 PM

Jdlrobson added a project: Verified.Nov 20 2023, 3:30 AM

Specify skin field in MobileWebUIActionsClosed, ResolvedPublic2 Estimated Story PointsActions