Page MenuHomePhabricator

Special:LinkSearch does not display results for links containing colon
Closed, ResolvedPublic

Description

Special:LinkSearch does not display results for links containing colon

Compare:

https://cs.wikipedia.org/wiki/Special:LinkSearch/commons.wikimedia.org/wiki/Category

and

https://cs.wikipedia.org/wiki/Special:LinkSearch/commons.wikimedia.org/wiki/Category:

I did not try any other not alphanum chars, but I would assume, that the issue might be in not consistent urlencoding / nourlencoding between the form value and the value stored in database.


Version: 1.18.x
Severity: major

Details

Reference
bz33029

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 12:05 AM
bzimport set Reference to bz33029.
bzimport added a subscriber: Unknown Object (MLST).
Danny_B created this task.Dec 13 2011, 2:09 PM

Looks like it's actually colon-specific. LinkSearch is assuming anything before the colon is a protocol (URI scheme). If there is no colon it defaults to 'http://', but with an unrecognizable protocol it defaults to the empty string.

Thanks Elliott! (For future reference: Writing "Bug: 33029" instead of "Bug:33029" will create an automatic notification in this bug report.)

Change 84475 had a related patch set uploaded by Ejegg:
LinkSearch: use default protocol if unsupported

https://gerrit.wikimedia.org/r/84475

Change 84475 merged by jenkins-bot:
LinkSearch: use default protocol if unsupported

https://gerrit.wikimedia.org/r/84475

Thank you for your patch :)