In patch https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/967918 we have added a test to check Vector and Vector 2022 Skin dependency against performance size budgets for styles and scripts.
We want to generalise that approach to be able to use it in more skins (specifically Minerva)
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Duplicate | None | T337404 [EPIC] Web Performance SLOs CI | |||
| Resolved | Edtadros | T346813 Vector performance budget's should consider modules added by hooks | |||
| Declined | None | T350292 Apply performance budget to Minerva skin |
Change 970827 had a related patch set uploaded (by Mabualruz; author: Mabualruz):
[mediawiki/skins/MinervaNeue@master] Performance budget's should consider modules added by hooks
Change 970828 had a related patch set uploaded (by Mabualruz; author: Mabualruz):
[mediawiki/skins/Vector@master] Performance budget's should consider modules added by hooks
Change 970826 had a related patch set uploaded (by Mabualruz; author: Mabualruz):
[mediawiki/core@master] Performance budget's should consider modules added by hooks
@Mabualruz suggesting we move this to sprint 4 to allow us a chance to assess and iron out any issues we might find with the existing solution for Vector.
Change 971426 had a related patch set uploaded (by Mabualruz; author: Mabualruz):
[mediawiki/skins/Vector@master] Performance budget Test message update
Change 971426 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Performance budget Test message update
Change 970827 abandoned by Jdlrobson:
[mediawiki/skins/MinervaNeue@master] Elevate the solution of Performance budget's to be used by more skins
Reason:
Will post on task
I think having this on Vector only is sufficient. It seems to be catching the sort of issues we cared about e.g. T358432. Since most code on Minerva is a subset of Vector 2022 now, any issue with Minerva should also be flagged on Vector.
Having it on Minerva and Vector might cause too much unnecessary friction for situations where we intend bytes to increase as it would mean adjusting the budget for both skins so I am declining this ticket.
We can reopen if we have strong motivation for doing this.
Change 970828 abandoned by Jdlrobson:
[mediawiki/skins/Vector@master] Elevate the solution of Performance budget's to be used by more skins
Reason:
Change 970826 abandoned by Jdlrobson:
[mediawiki/core@master] Elevate the solution of Performance budget's to be used by more skins
Reason:
https://phabricator.wikimedia.org/T350292 was declined.