Page MenuHomePhabricator
Create Task
Maniphest T350369

Errors in mw-client-NEW-errors TypeError: Cannot read properties of undefined (reading 'Keys')
Closed, ResolvedPublicBUG REPORT
Actions

Description

Stack Trace

at HTMLAnchorElement.phonosClickHandler  https://en.m.wikipedia.org/w/load.php?lang=en&modules=ext.centralNotice.choiceData%2Cdisplay%2CgeoIP%2CimpressionDiet%2CkvStore%2ClegacySupport%2CstartUp%7Cext.centralauth.ForeignApi%2Ccentralautologin%7Cext.checkUser.clientHints%7Cext.cite.ux-enhancements%7Cext.cx.entrypoints.languagesearcher.init%7Cext.cx.entrypoints.mffrequentlanguages%7Cext.cx.eventlogging.campaigns%7Cext.cx.model%7Cext.echo.centralauth%7Cext.eventLogging%2CnavigationTiming%2Cpopups%2CwikimediaEvents%7Cext.growthExperiments.SuggestedEditSession%7Cext.phonos.init%7Cext.relatedArticles.readMore.bootstrap%7Cext.urlShortener.toolbar%7Cjquery%2Coojs%2Csite%7Cjquery.client%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Crouter%2Cstorage%2Ctemplate%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.ForeignApi.core%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.media%2Cready%7Cmediawiki.page.watch.ajax%7Cmediawiki.template.mustache%7Cmobile.init%2Cstartup%7Cmobile.ooui.icons%7Cmobile.pagelist.styles%7Cmobile.pagesummary.styles%7Cmobile.placeholder.images%7Cmobile.startup.images%7Cmw.cx.SiteMapper%7Cmw.externalguidance.init%7Cskins.minerva.icons.images.scripts.misc%7Cskins.minerva.icons.page.issues.default.color%7Cskins.minerva.icons.page.issues.medium.color%7Cskins.minerva.icons.page.issues.uncolored%7Cskins.minerva.messageBox.styles%7Cskins.minerva.scripts&skin=minerva&version=p7wcv:192:262

File Url

https://en.m.wikipedia.org/w/load.php?lang=en&modules=ext.centralNotice.choiceData%2Cdisplay%2CgeoIP%2CimpressionDiet%2CkvStore%2ClegacySupport%2CstartUp%7Cext.centralauth.ForeignApi%2Ccentralautologin%7Cext.checkUser.clientHints%7Cext.cite.ux-enhancements%7Cext.cx.entrypoints.languagesearcher.init%7Cext.cx.entrypoints.mffrequentlanguages%7Cext.cx.eventlogging.campaigns%7Cext.cx.model%7Cext.echo.centralauth%7Cext.eventLogging%2CnavigationTiming%2Cpopups%2CwikimediaEvents%7Cext.growthExperiments.SuggestedEditSession%7Cext.phonos.init%7Cext.relatedArticles.readMore.bootstrap%7Cext.urlShortener.toolbar%7Cjquery%2Coojs%2Csite%7Cjquery.client%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Crouter%2Cstorage%2Ctemplate%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.ForeignApi.core%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.media%2Cready%7Cmediawiki.page.watch.ajax%7Cmediawiki.template.mustache%7Cmobile.init%2Cstartup%7Cmobile.ooui.icons%7Cmobile.pagelist.styles%7Cmobile.pagesummary.styles%7Cmobile.placeholder.images%7Cmobile.startup.images%7Cmw.cx.SiteMapper%7Cmw.externalguidance.init%7Cskins.minerva.icons.images.scripts.misc%7Cskins.minerva.icons.page.issues.default.color%7Cskins.minerva.icons.page.issues.medium.color%7Cskins.minerva.icons.page.issues.uncolored%7Cskins.minerva.messageBox.styles%7Cskins.minerva.scripts&skin=minerva&version=p7wcv

Error count

1,168

Logstash Url

https://logstash.wikimedia.org/app/dashboards#/view/AXDBY8Qhh3Uj6x1zCF56?_g=h@d942f56&_a=h@09cc74a

Details

SubjectRepoBranchLines +/-
Use static integers instead of OO.ui.Keysmediawiki/extensions/Phonosmaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

• Mabualruz created this task.Nov 2 2023, 11:58 AM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptNov 2 2023, 11:58 AM
• Mabualruz added projects: Desktop Improvements (Vector 2022), Web-Team-Backlog.Nov 2 2023, 11:59 AM
ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3); removed Web-Team-Backlog.Nov 2 2023, 12:02 PM
Jdlrobson edited projects, added MediaWiki-extensions-Phonos, Wikimedia-production-error; removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3), Desktop Improvements (Vector 2022).Nov 2 2023, 5:12 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptNov 2 2023, 5:12 PM
Jdlrobson subscribed.Nov 2 2023, 5:12 PM

Mo will add error rate and link to logstash.

• Mabualruz updated the task description. (Show Details)Nov 2 2023, 5:17 PM
In T350369#9302765, @Jdlrobson wrote:

Mo will add error rate and link to logstash.

Done

Nardog subscribed.Nov 4 2023, 9:52 AM
TheresNoTime edited projects, added Community-Tech (CommTech-Kanban); removed Community-Tech.Nov 6 2023, 10:38 AM
TheresNoTime moved this task from Ready 🎬 to Needs Attention 👀 on the Community-Tech (CommTech-Kanban) board.
TheresNoTime added subscribers: Samwilson, TheresNoTime.Nov 6 2023, 10:55 AM

TypeError: Cannot read properties of undefined (reading 'Keys') introduced by OO.ui.Keys.ENTER (1af2997)? I can't replicate this though..

Related: rEPHN1af2997bad71: Trigger button on enter as well as click, T347056: Unable to activate Phonos button with keyboard when it has an error

Samwilson added a comment.Nov 6 2023, 11:02 AM

I guess this happens on a page where no OOUI is used elsewhere? i.e. we're trying to avoid using OOUI before the click, but then to determine the click we're using it! Oops. (My mistake, I think.) We can probably just use the key's codes directly (or maybe via variables for easier reading).

Nardog mentioned this in T350949: Play music requires a futher click on mobile browsers.Nov 10 2023, 7:46 PM
gerritbot added a comment.Nov 11 2023, 4:21 PM

Change 973387 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/Phonos@master] Use static integers instead of OO.ui.Keys

https://gerrit.wikimedia.org/r/973387

gerritbot added a project: Patch-For-Review.Nov 11 2023, 4:21 PM
Fomafix subscribed.Nov 11 2023, 4:21 PM

modules/ext.phonos.init.js uses OO.ui.Keys. OO.ui.Keys is defined in module oojs-ui-core. In extension.json there is no dependency on this module. Therefor error can happen if the module in not loaded yet.

oojs-ui-core is a very large module. A dependency requires to load this large module just for the small static values:

OO.ui.Keys.ENTER = 13;
OO.ui.Keys.SPACE = 32;

I suggest to use the static integers instead of adding a dependency on module oojs-ui-core. I created I10c7fd827be559ba8dcdec01c38ee6ace63922aa (https://gerrit.wikimedia.org/r/973387) for this.

gerritbot added a comment.Nov 12 2023, 12:41 AM

Change 973387 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] Use static integers instead of OO.ui.Keys

https://gerrit.wikimedia.org/r/973387

Fomafix mentioned this in rEPHN365e80b9f580: Use static integers instead of OO.ui.Keys.Nov 12 2023, 12:41 AM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 12 2023, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 12 2023, 1:10 AM
TheDJ removed a project: Wikimedia-production-error.Nov 17 2023, 1:12 PM
TheDJ subscribed.

The issue has dropped from logstash. Keeping ticket open so that the team can complete their own processes.

MusikAnimal closed this task as Resolved.Dec 20 2023, 3:23 AM
MusikAnimal assigned this task to Fomafix.
MusikAnimal moved this task from Needs Attention 👀 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.
MusikAnimal subscribed.

Fomafix's approach seems perfect given the circumstances (we don't want to load OOUI on page load). Thank you for taking care of this!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits