Page MenuHomePhabricator

Thanking an edit more than once
Open, Needs TriagePublicBUG REPORT

Description

You can thank an edit again after thanking it once. However, excessive thanks neither notify the other person nor appear in Special:Log.

This bug appears about months ago.

Steps to replicate the issue (include links if applicable):

  1. View the history of any page, choose an edit to thank, then click the "thank" link at the end of that edit.
  2. The person being thanked is notified.
  3. Open Special:Log, select "Thanks log", your can find your thanks in it.
  4. Refresh history page, then thank the same edit again.
  5. Refresh the page and thank again. This time, open the "thank" link in the new tab.

What happens?:

  1. When you refresh the history page, the "thank" link is still clickable. Clicking it allows you to thank in-page.
  2. If you open that link in a new tab, a big blue "Send thanks" button still appears.
  3. The person being thanked is not notified again. More thanks will not appear in Special:Log. (Which is good civilization.)

What should have happened instead?:

  1. When you refresh the history page, the "thank" link you have clicked should turn into a "thanked" text.
  2. If you open that link in a new tab, the blue button should not appear.

Software version (skip for WMF-hosted wikis like Wikipedia):
Can reproduce in Wikipedia.

Other information (browser name/version, screenshots, etc.):

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenBUG REPORTNone

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Thx, @TripleCamera2022 for filing the issue. I checked in beta and testwiki wmf.3 - thanked status seems to be persistent; refreshing View history page (or opening it in a different tab) doesn't change the status of an edit to be thanked.
Also, I checked in Chrome and FF and in non-article namespaces. Is there any more details that you may add to the issue steps that help me to reproduce the issue?

Thx, @TripleCamera2022 for filing the issue. I checked in beta and testwiki wmf.3 - thanked status seems to be persistent; refreshing View history page (or opening it in a different tab) doesn't change the status of an edit to be thanked.
Also, I checked in Chrome and FF and in non-article namespaces. Is there any more details that you may add to the issue steps that help me to reproduce the issue?

I just checked on English Wikipedia, and I failed to reproduced this issue :(. However, it can be reproduced on Chinese Wikipedia and some other Chinese wiki sites my friends host.

Update: I checked Chinese Wikipedia again, the status became "thanked". That is weird. So I checked carefully in English Wikipedia, Chinese Wikipedia, and a self-hosted wiki (Project Archive). Here are the results:

  • English Wikipedia: On user contributions page and view history page, the status is "thanked". When accessing Special:Thanks/<Revision you have thanked>, the "send thanks" button is still available. (I don't know if this is expected behavior.)
  • Chinese Wikipedia: On user contributions page and view history page, the status is "thanked". When accessing Special:Thanks/<Revision you have thanked>, the "send thanks" button is still available.
  • Project Archive: On user contributions page and view history page, the link is still "thank". When accessing Special:Thanks/<Revision you have thanked>, the "send thanks" button is still available.

Thanks @TripleCamera2022 for re-checking and providing some additional information!
Moved the task to Needs Discussion for reviewing the cases you mentioned where the "send thanks" button is available.

I checked it one more time yesterday on my phone. I found that it can be reproduced on my phone, but not on my computer.
Screenshots in English Wikipedia:
Computer:

T350421_wp_computer.png (722×2 px, 150 KB)

Phone:
T350421_wp_phone.jpg (1×2 px, 340 KB)

(In Chinese Wikipedia the situation is same.)

I also tested this on 3 self-hosted wikis. On two of them this can be reproduced stably, on another one this can only be reproduced on my phone. I have no idea why this happens.

This issue was observed on Metawiki.

I have encountered this behavior multiple times on some wikis (English, Metawiki) a couple, but forgot to report it then. Today while searching for related issues, I arrived here and decided to document it.

A few days ago I thanked a user for his edit. Immediately after thanking I remember the interface correctly changed from 'Thank' to 'Thanked'.

Today while coming across the same page I see the user was not thanked. The interface had reverted back to 'Thank'. Assuming that I had not thanked the user earlier, I clicked 'Thank' again.

Later when I checked the logs, I realized that the earlier thanks had already been recorded and the second click did not create a new log entry.

This behavior can easily make users believe that their earlier thanks was not recorded or has expired leading to confusion and repeated attempts to thank the same edit.

Wow. This ticket is still receiving comments after two years!

According to my understanding to the MediaWiki software now, thanks actions always succeed. MediaWiki checks if you have thanked the revision / log event before, if you have, nothing happens. If you haven't, MediaWiki creates a thanks log entry, and send a notification to the person being thanked.

The server cannot tell you which revisions / log events have been thanked by you and which are not: The thanks logs only contain the performer (the person sending the thank) and the target (the person receiving the thank), the revision / log IDs being thanked are stored in a private table. Plus, there is no API for this.

So, the browser has to remember which revisions / log events have been thanked by you. There is a JavaScript tool that disables the "thank" link for the events that have been thanked. So, this bug is probably caused by the JavaScript tool. I think this is a really bad design.

My explanation may not be 100% correct, feel free to point out the mistakes.