Page MenuHomePhabricator

Remove deprecated WikimediaUI Base tokens technical layer
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

Originally set out as useful middle-step to provide a longer time compatibility layer with OOUI and derived interfaces, we've set out to provide a huge number of deprecated tokens in Codex. Those would be fed into WikimediaUI Base and provide a (through this extra leg) single source of truth.
When starting to replace deprecated values, specifically in the group where no 1:1 token values where available in T331403, it became clear that the amount of time needed to immediately use the new token names, is certainly the faster way than to work in two step approach.
It also became clearer within first implementations, that the deprecated tokens, even though clearly marked, make it into new products. For best designer/developer experience we moved along getting rid of WikimediaUI Base compatibility layer.
It still makes understanding the replacement patches much simpler and helps in the code reviews. So it wasn't lost work.

Goal

Remove the deprecation layer, resulting in 'deprecated-aliases-wikimedia-ui-base' files from Codex after the code replacements in T334934 are successfully resolved.
Public code snippet of last v1.2.0: https://phabricator.wikimedia.org/P54580

Acceptance criteria

  • No deprecated alias token file is generated any more and the code responsible for it has been removed.

Event Timeline

Volker_E renamed this task from Remove deprecated tokens technical layer to Remove deprecated WikimediaUI Base tokens technical layer.

Change 987871 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] tokens, build: Remove deprecated WikimediaUI Base aliases and its build

https://gerrit.wikimedia.org/r/987871

Change 988110 had a related patch set uploaded (by VolkerE; author: VolkerE):

[oojs/ui@master] build: Remove obsolete deprecated WikimediaUI Base token alias file

https://gerrit.wikimedia.org/r/988110

Change 988110 merged by jenkins-bot:

[oojs/ui@master] build: Remove obsolete deprecated WikimediaUI Base token alias file

https://gerrit.wikimedia.org/r/988110

AnneT set the point value for this task to 1.Jan 8 2024, 6:42 PM

Change 987871 merged by jenkins-bot:

[design/codex@main] tokens, build: Remove deprecated WikimediaUI Base aliases and its build

https://gerrit.wikimedia.org/r/987871

Change 989237 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/core@master] Update OOUI to v0.48.4

https://gerrit.wikimedia.org/r/989237

Change 989237 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.48.4

https://gerrit.wikimedia.org/r/989237

Change 989250 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/core@master] Update Codex from v1.2.0 to v1.2.1

https://gerrit.wikimedia.org/r/989250

Change 989250 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.2.0 to v1.2.1

https://gerrit.wikimedia.org/r/989250