Page MenuHomePhabricator

Auto-Rescue Edge Cases
Closed, ResolvedPublic

Description

Code changes:

Questions:

  • We have an alert if there are more than 5 recurring donations sitting in Processing, remove that if we are using it - we aren't going to use that status
  • We have a hard stop on two charges within 23 days, how do we want to change that in relation to this?
  • What happens if we never get an update from Adyen to one that is being rescued - There is paypal code that eventually cancels recurrings we haven't heard from we can use that same idea here
  • What happens when a status Pending for autorescue goes back into the charge cycle the next day?
  • Add a cc check, SEPA is available but we will do credit card first T351340: Limit auto rescue to credit cards
  • Remove Auto Rescue Message from Pending Database T356224

Event Timeline

@EMartin When a donation is autorescued, do we want to change the day of the month we charge that donation on in the next month? For example:
Current flow:
November 21 - donation fails, we try 3 times
November 23 - donation succeeds, we set the date for the next charge to December 21

Current Auto rescue flow:
November 21 - donation fails, goes into auto rescue
December 2 - donation succeeds, we set the date for the next charge to December 21

Proposed Auto rescue flow:
November 21 - donation fails, goes into auto rescue
December 2 - donation succeeds, we set the date for the next charge to January 2

Pros- friendlier to the donor as charges are still month apart (or more), might be a better day of the month to charge that donor in the future
Cons - longer time between when the donation initially was charged and when the charge happens

@Cstone no, we should maintain the original billing cycle. Is there a reason we didn't go with account level auto rescue?

@EMartin good question, I went looking and looks like we decided it at the beginning of the project, linking to the comment talking about it https://phabricator.wikimedia.org/T331920#8957231

XenoRyet set Final Story Points to 2.