Currently we check-and-set ParserOutput::getCacheTime(), ::getCacheRevisionId(), ::getTimestamp() and ::getRenderId() in multiple places.
These should be moved earlier in the parse pipeline (in particular pulled into ContentRenderer) and instead turned into deprecation warnings (and later thrown exceptions) asserting that the properties have already been set.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T350538 Move all cache property initialization into ContentRenderer | |||
| Resolved | BUG REPORT | MSantos | T353689 REST HTML endpoint returning 500 for JSON page | ||
| Open | BUG REPORT | daniel | T349868 page/<title>/html and with_html endpoints fails with InvalidArgumentException for overridden interface messages with JSON content | ||
| Resolved | PRODUCTION ERROR | None | T358709 Parser output missing render ID | ||
| Open | PRODUCTION ERROR | None | T358708 Inconsistent revision ID |
Change 957773 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/core@master] Add ParserOutput::{get,set}RenderId() and set render id in ContentRenderer
Change 971980 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/core@master] [poolcounter] Remove incomplete workaround for T48014
Change 971981 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/core@master] [ParserCache] Add logging for T350538
Change 971982 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/core@master] [ParsoidParser] Warn if render ID is not set
Change 957773 merged by jenkins-bot:
[mediawiki/core@master] Add ParserOutput::{get,set}RenderId() and set render id in ContentRenderer
Change 971980 merged by jenkins-bot:
[mediawiki/core@master] [poolcounter] Remove incomplete workaround for T48014
Change 971981 merged by jenkins-bot:
[mediawiki/core@master] [ParserCache] Add logging for T350538
Change 999082 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/core@master] [ParsoidParser] Add warning to ParsoidParser::setParsoidRenderID()
Change 1007418 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/core@master] Tighten up phan type for ContentRenderer::getParserOutput()
Change 1007418 merged by jenkins-bot:
[mediawiki/core@master] Tighten up phan type for ContentRenderer::getParserOutput()
Change #999082 abandoned by C. Scott Ananian:
[mediawiki/core@master] [ParsoidParser] Add warning to ParsoidParser::setParsoidRenderID()
Reason:
The call chain is actually ContentRenderer->ContentHandler->ParsoidParser, so the ContentRenderer won't get a chance to set the render ID here until after the ParsoidParser returns.
Change #971982 merged by jenkins-bot:
[mediawiki/core@master] [ParsoidParser] Remove unneeded code to set render ID