Page MenuHomePhabricator
Create Task
Maniphest T350608

Add and use error types: Reached recursion limit in orchestrator (evaluator)
Closed, ResolvedPublic
Actions

Description

Description

copied from discussion (Oct. 26, Oct. 31) in T321115:

src/execute.js: Aborting because argument resolution contains cyclical references: ...

This one seems tough: it seems not to fit well with any of our existing error types, but also seems too specialized to warrant a new error type. ...

The recursion limit one should be a bespoke type, alongside Z570/Z571 for exceeding the rate limit, I think.

After the orchestrator error type exists, use it to upgrade the orchestrator error mentioned above.

Completion checklist

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
wikifunctions: Switch Python evaluator to 2023-11-29-143341 (try 3)operations/deployment-chartsmaster+1 -1
wikifunctions: Switch JavaScript evaluator to 2023-11-29-143341operations/deployment-chartsmaster+1 -1
wikifunctions: Switch Python evaluator to 2023-11-29-143341operations/deployment-chartsmaster+1 -1
wikifunctions: Switch orchestrator to 2023-11-17-200241operations/deployment-chartsmaster+1 -1
wikifunctions: Switch JavaScript evaluator to 2023-11-22-195017operations/deployment-chartsmaster+1 -1
wikifunctions: Bump evaluators to 2023-11-20-171133operations/deployment-chartsmaster+2 -2
Update function-schemata sub-module to HEAD (17c4936)mediawiki/extensions/WikiLambdamaster+1 -1
Customize query in gerrit
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Use orchestrator_recursion_limit in execute.jsrepos/abstract-wiki/wikifunctions/function-orchestrator!88dmartinT350608main
Update function-schemata sub-module to HEAD (17c4936)repos/abstract-wiki/wikifunctions/wikilambda-cli!19dmartinsync-function-schematamain
Update function-schemata sub-module to HEAD (17c4936)repos/abstract-wiki/wikifunctions/function-orchestrator!85dmartinsync-function-schematamain
Update function-schemata sub-module to HEAD (17c4936)repos/abstract-wiki/wikifunctions/function-evaluator!104dmartinsync-function-schematamain
definitions: Add recursion limit error types Z572 for orchestrator and Z573 for evaluatorrepos/abstract-wiki/wikifunctions/function-schemata!52dmartinT350608main
Customize query in GitLab

Related Objects
Search...

Event Timeline

DMartin-WMF created this task.Nov 6 2023, 5:49 PM
DMartin-WMF added a parent task: T321114: Don't create generic errors in the orchestrator, but specific custom ones.Nov 6 2023, 5:53 PM
CodeReviewBot added a project: Patch-For-Review.Nov 7 2023, 2:23 AM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/52

Add 2 error types: Reached recursion limit in orchestrator (evaluator)

CodeReviewBot added a comment.Nov 7 2023, 2:25 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/52

definitions: Add recursion limit error types Z572 for orchestrator and Z573 for evaluator

Maintenance_bot removed a project: Patch-For-Review.Nov 7 2023, 2:30 PM
DMartin-WMF closed this task as Resolved.Nov 7 2023, 4:32 PM
DMartin-WMF claimed this task.
DMartin-WMF renamed this task from Add error types: Reached recursion limit in orchestrator (evaluator) to Add and use error types: Reached recursion limit in orchestrator (evaluator).Nov 7 2023, 5:07 PM
DMartin-WMF reopened this task as Open.
DMartin-WMF updated the task description. (Show Details)
DMartin-WMF updated the task description. (Show Details)

Reopening until the orchestrator error type has been used for the error mentioned in the description.

DMartin-WMF mentioned this in T321115: Don't hard-code English-language error messages in the orchestrator; have pre-defined custom ones.Nov 8 2023, 3:28 PM
gerritbot added a comment.Nov 14 2023, 7:08 PM

Change 974256 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (17c4936)

https://gerrit.wikimedia.org/r/974256

gerritbot added a project: Patch-For-Review.Nov 14 2023, 7:08 PM
CodeReviewBot added a comment.Nov 14 2023, 7:10 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/104

Update function-schemata sub-module to HEAD (17c4936)

CodeReviewBot added a comment.Nov 14 2023, 7:11 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/85

Update function-schemata sub-module to HEAD (17c4936)

CodeReviewBot added a comment.Nov 14 2023, 7:11 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/19

Update function-schemata sub-module to HEAD (17c4936)

CodeReviewBot added a comment.Nov 14 2023, 7:23 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/19

Update function-schemata sub-module to HEAD (17c4936)

gerritbot added a comment.Nov 14 2023, 7:27 PM

Change 974256 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (17c4936)

https://gerrit.wikimedia.org/r/974256

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Nov 14 2023, 8:01 PM
CodeReviewBot added a comment.Nov 14 2023, 8:07 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/85

Update function-schemata sub-module to HEAD (17c4936)

CodeReviewBot added a comment.Nov 14 2023, 8:12 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/104

Update function-schemata sub-module to HEAD (17c4936)

Maintenance_bot removed a project: Patch-For-Review.Nov 14 2023, 8:30 PM
Jdforrester-WMF subscribed.Nov 14 2023, 8:39 PM

Once this is live (wmf.7), we'll need to follow https://wikitech.wikimedia.org/wiki/Wikifunctions/Runbook#Add_a_new_pre-defined_Object_in_production

CodeReviewBot added a project: Patch-For-Review.Nov 15 2023, 4:34 AM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/88

Use orchestrator_recursion_limit in execute.js

DMartin-WMF mentioned this in T287919: Audit ad Hoc Error Types in Orchestrator.Nov 16 2023, 5:59 AM
CodeReviewBot added a comment.Nov 16 2023, 4:41 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/88

Use orchestrator_recursion_limit in execute.js

Maintenance_bot removed a project: Patch-For-Review.Nov 16 2023, 5:10 PM
Jdforrester-WMF changed the task status from Open to In Progress.Nov 16 2023, 5:23 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To Triage to To deploy on the Abstract Wikipedia team board.
gerritbot added a comment.Nov 20 2023, 5:28 PM

Change 975867 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Bump evaluators to 2023-11-20-171133

https://gerrit.wikimedia.org/r/975867

gerritbot added a project: Patch-For-Review.Nov 20 2023, 5:28 PM
gerritbot added a comment.Nov 20 2023, 5:36 PM

Change 975867 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Bump evaluators to 2023-11-20-171133

https://gerrit.wikimedia.org/r/975867

Maintenance_bot removed a project: Patch-For-Review.Nov 20 2023, 6:11 PM
gerritbot added a comment.Nov 22 2023, 8:10 PM

Change 976846 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Switch JavaScript evaluator to 2023-11-22-195017

https://gerrit.wikimedia.org/r/976846

gerritbot added a project: Patch-For-Review.Nov 22 2023, 8:10 PM

Change 976847 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Switch Python evaluator to 2023-11-22-195017

https://gerrit.wikimedia.org/r/976847

gerritbot added a comment.Nov 22 2023, 8:11 PM

Change 976848 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Switch orchestrator to 2023-11-17-200241

https://gerrit.wikimedia.org/r/976848

gerritbot added a comment.Nov 27 2023, 2:37 PM

Change 976846 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Switch JavaScript evaluator to 2023-11-22-195017

https://gerrit.wikimedia.org/r/976846

gerritbot added a comment.Nov 29 2023, 4:50 PM

Change 976848 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Switch orchestrator to 2023-11-17-200241

https://gerrit.wikimedia.org/r/976848

Jdforrester-WMF added a comment.Nov 29 2023, 5:35 PM

The code to use this is now live in the orchestrator, but the ZObject also needs to be manually created on wikifunctions.org via the script.

gerritbot added a comment.Nov 29 2023, 7:04 PM

Change 976847 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Switch Python evaluator to 2023-11-29-143341

https://gerrit.wikimedia.org/r/976847

Maintenance_bot removed a project: Patch-For-Review.Nov 29 2023, 7:10 PM
gerritbot added a comment.Nov 29 2023, 7:18 PM

Change 978678 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Switch JavaScript evaluator to 2023-11-29-143341

https://gerrit.wikimedia.org/r/978678

gerritbot added a project: Patch-For-Review.Nov 29 2023, 7:18 PM
gerritbot added a comment.Nov 29 2023, 7:20 PM

Change 978678 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Switch JavaScript evaluator to 2023-11-29-143341

https://gerrit.wikimedia.org/r/978678

Maintenance_bot removed a project: Patch-For-Review.Nov 29 2023, 7:30 PM
gerritbot added a comment.Nov 29 2023, 8:54 PM

Change 978514 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Switch Python evaluator to 2023-11-29-143341 (try 3)

https://gerrit.wikimedia.org/r/978514

gerritbot added a project: Patch-For-Review.Nov 29 2023, 8:54 PM
gerritbot added a comment.Nov 29 2023, 8:57 PM

Change 978514 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Switch Python evaluator to 2023-11-29-143341 (try 3)

https://gerrit.wikimedia.org/r/978514

Maintenance_bot removed a project: Patch-For-Review.Nov 29 2023, 9:11 PM
Jdforrester-WMF closed this task as Resolved.Dec 4 2023, 7:12 PM
Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.
Jdforrester-WMF mentioned this in rMSFE68632c1f827a: Update function-schemata sub-module to HEAD (17c4936).Oct 3 2025, 9:38 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits