Page MenuHomePhabricator

Patrol link on diff pages disappeared on Persian Wikipedia
Closed, DuplicatePublicBUG REPORT

Description

Steps to replicate the issue:

  • See this unpatrolled page on a desktop computer. If you have patroller right you'll see a link labeled "[به این صفحه برچسب گشت بزن]" to patrol the whole page.
  • now go to this diff page (the second revision of that page), again, using a desktop computer. You will see the patrol link labeled "[برچسب گشت بزن]" below the text difference section.
  • Now open both links using a mobile device. You will probably see the patrol link on the page itself, but you won't see it on the diff page.

What happens?:
Patrol link on diff pages disappeared on mobile devices. If you view the diff page using the MinervaNeue skin on a desktop computer, the patrol link is still present.

Other information:
Based on a report on Persian Wikipedia, I guess the issue reported on T350515 may have a similar origin as they appeared at the same time.

Event Timeline

(I don't have patroller right so was unable to check this right now). Would be helpful if someone can determine what CSS is responsible for hidding the link and if this is also caused by FlaggedRevisions loading mediawiki.diff.styles out of context (and thus require an answer to T350596 for how to organize these styles more reliably).

I don't have patroller right so was unable to check this right now.

I gave autopatrolled and patroller rights to your account (Jdlrobson) on fawiki.

Would be helpful if someone can determine what CSS is responsible for hidding the link

As far as I can see, when you zoom in on the diff page, the display: none attribute of the div with class mw-diff-revision-history-links is struck through, and a new div with the same class appears with display: flex.
I can see a new @media (max-width: 1000px) above the new div after zooming, but as I am not that familiar with CSS, I don't know what that means. However, according to the description of T350515, I think it can be related to this issue.
Thanks.

Change 972872 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Restore content below diff

https://gerrit.wikimedia.org/r/972872

Change 972872 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Restore content below diff

https://gerrit.wikimedia.org/r/972872

Edtadros subscribed.

I don't have patrol permissions unfortunately so I cannot validate this.

@Jdlrobson Please close this task as T350454 and the issue addressed here are resolved. Thanks.