Page MenuHomePhabricator
Create Task
Maniphest T350652

Removing all course reruns allows message bundle to be translated to all languages
Closed, ResolvedPublic4 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Create a block in a base course
  • Allow translation of that course into other languages
  • Delete the block from base and translated courses

What happens?:
The WikiLearn system informs Meta-Wiki that no languages are needed by sending an empty priorityLanguages array since they no longer need any translation.
On Meta-Wiki, translation of that message bundle is now allowed into all languages.

What should have happened instead?:
Translation should not be allowed on Meta-Wiki

Software version (skip for WMF-hosted wikis like Wikipedia):

  • MediaWiki: master
  • Translate: master

Other information (browser name/version, screenshots, etc.):
Sample message bundles with this issue:

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
MessageBundle: Stop translation based on prioritylangs and priorityforceWangombemediawiki/extensions/Translatemaster+32 -5
Translate extension: Ignore translation of concatenated messagesWangombetranslatewikimaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

abi_ created this task.Nov 7 2023, 5:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 7 2023, 5:05 AM
abi_ added a comment.Nov 7 2023, 5:28 AM

One simple fix for this would be to not allow translation to any language if priorityLanguages is [] and allowOnlyPriorityLanguages is true.

Another option would be to add a separate`@metadata` property or delete the course entirely on MetaWiki if there are no priorities set.

Tacsipacsi subscribed.Nov 7 2023, 12:57 PM

On translatable pages, AFAIK it’s usually handled by setting priority languages to ['en'] (or whatever the source language is) and then setting allowOnlyPriorityLanguages to true. However, handling the empty array as you propose would be a cleaner solution, and I can think of no workflows/cases it would break.

Nikerabbit triaged this task as Medium priority.Jan 15 2024, 11:55 AM
Nikerabbit moved this task from Backlog to group management on the MediaWiki-extensions-Translate board.
Nikerabbit lowered the priority of this task from Medium to Low.Jan 16 2024, 8:59 AM
Nikerabbit edited projects, added: Language-Team (Language-2024-January-March); removed: Language-Team (Language-2023-October-December).
Nikerabbit set the point value for this task to 4.
Nikerabbit moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2024-January-March) board.Jan 16 2024, 9:02 AM
Nikerabbit added a project: Localization Infrastructure FY2023-24.
Nikerabbit moved this task from Backlog to Support (LM) on the Localization Infrastructure FY2023-24 board.
• Wangombe changed the task status from Open to In Progress.Feb 12 2024, 7:44 AM
• Wangombe claimed this task.
• Wangombe moved this task from Priority: Localization infrastructure to In Progress on the Language-Team (Language-2024-January-March) board.
gerritbot added a comment.Feb 13 2024, 1:23 PM

Change 1002982 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] MessageBundles: Limit translation if no priority languages are set

https://gerrit.wikimedia.org/r/1002982

gerritbot added a project: Patch-For-Review.Feb 13 2024, 1:23 PM
abi_ moved this task from In Progress to In Review on the Language-Team (Language-2024-January-March) board.Feb 26 2024, 6:12 PM
gerritbot added a comment.Mar 6 2024, 9:02 PM

Change 1009352 had a related patch set uploaded (by Wangombe; author: Wangombe):

[translatewiki@master] Ignore tpt-translation-restricted-no-priority-languages-int message

https://gerrit.wikimedia.org/r/1009352

Tacsipacsi mentioned this in T359975: Allow enforcing empty priority languages on translatable pages.Mar 12 2024, 6:16 PM
gerritbot added a comment.Mar 13 2024, 2:30 PM

Change 1002982 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] MessageBundle: Stop translation based on prioritylangs and priorityforce

https://gerrit.wikimedia.org/r/1002982

abi_ moved this task from In Review to Check after deployment on the Language-Team (Language-2024-January-March) board.Mar 13 2024, 3:24 PM

Tested on translatewiki.net: https://translatewiki.net/wiki/Special:Translate?group=messagebundle-User%3AAbijeet+Patro%2FMB-NoPriority&language=es&filter=%21translated&action=translate

image.png (983×497 px, 57 KB)

Will check on Meta-Wiki as well. Leaving it open for that.

gerritbot added a comment.Mar 13 2024, 4:05 PM

Change 1009352 merged by jenkins-bot:

[translatewiki@master] Translate extension: Ignore translation of concatenated messages

https://gerrit.wikimedia.org/r/1009352

Maintenance_bot removed a project: Patch-For-Review.Mar 13 2024, 4:32 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.23; 2024-03-19).Mar 13 2024, 7:01 PM
abi_ closed this task as Resolved.Mar 21 2024, 1:28 PM
abi_ moved this task from Check after deployment to Done on the Language-Team (Language-2024-January-March) board.

This works as expected:

image.png (1,296×591 px, 103 KB)

There is a separate issue with styles not being applied to the warnings. I'll file a separate bug report for that.

Tacsipacsi added a comment.Mar 24 2024, 1:37 PM
In T350652#9649332, @abi_ wrote:

There is a separate issue with styles not being applied to the warnings. I'll file a separate bug report for that.

See also T360668: Drop support for non-Codex message boxes (mw-message-box).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits