Page MenuHomePhabricator
Create Task
Maniphest T350906

Review database schema of the WikimediaCampaignEvents extension
Closed, ResolvedPublic
Actions

Description

Disclaimer: there doesn't seem to be a request template in https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment#Preparing_for_deployment, so I'm not quite sure what information is needed here. We'd be happy to provide any additional needed information, ça va sans dire.

We would like to request a DBA review of the schema of the WikimediaCampaignEvents extension.

Schema to review:

Location
The new table will leave together with the tables of the CampaignEvents extension. Currently, this means:

  • Beta: the wikishared database in x1
  • Prod: the wikishared database in x1, as well as the testwiki, test2wiki, and officewiki databases also in x1.

Deployment date
Tentatively December 2023, but it could be later if the deployment process takes longer.

Further information
An overview of the tool, team contacts etc. are also available in the security review task: T350900

Related Objects
Search...

Event Timeline

Daimona created this task.Nov 9 2023, 6:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 9 2023, 6:07 PM
Daimona moved this task from Backlog to Following on the Connection-Team board.Nov 9 2023, 6:07 PM
Daimona mentioned this in T347896: Prepare the WikimediaCampaignEvents extension for deployment.
Daimona added a parent task: T347896: Prepare the WikimediaCampaignEvents extension for deployment.
Marostegui assigned this task to Ladsgroup.Nov 9 2023, 6:22 PM
Marostegui triaged this task as Medium priority.
Marostegui moved this task from Triage to Pending comment on the DBA board.
Ladsgroup added a comment.Nov 13 2023, 4:48 PM

My only question is wceg_grant_id seems to blob but it looks like an id? Can I have some examples?

What is the rough number of rows? I don't think it'll be a lot. Generally speaking this looks good to me.

Daimona added a subscriber: cmelo.EditedNov 13 2023, 6:17 PM
In T350906#9327304, @Ladsgroup wrote:

My only question is wceg_grant_id seems to blob but it looks like an id? Can I have some examples?

Sure: these IDs are retrieved from Fluxx, and as far as they know, they are in the form XXXX-XXXXX (where Xs are numbers). We chose to store them without any processing because we did not have guarantees on the exact format IIRC (CC @cmelo), and also because Fluxx does dubious things with its IDs (e.g., add letters to the prefix depending on the status of the grant).

What is the rough number of rows? I don't think it'll be a lot. Generally speaking this looks good to me.

Yup, it should be really small. According to the current estimates, it would be around ~300 rows per year.

Ladsgroup added a comment.Nov 13 2023, 6:19 PM

Then go ahead.

Daimona added a comment.Nov 13 2023, 6:21 PM
In T350906#9327624, @Ladsgroup wrote:

Then go ahead.

Thanks! Can this task be resolved then? I will create new tasks for the actual creation of these tables when we get there.

Ladsgroup added a comment.Nov 13 2023, 6:25 PM

Sure but we don't create the tables ourselves so it's on your hands totally

Daimona closed this task as Resolved.Nov 14 2023, 1:24 PM
In T350906#9327644, @Ladsgroup wrote:

Sure but we don't create the tables ourselves so it's on your hands totally

Yeah, sorry, I just meant to say that I will create new tasks for us to create the table, and just reference this one for DBA approval. Closing as resolved then, thanks again!

Daimona mentioned this in T347909: Deploy the WikimediaCampaignEvents extension to production.Feb 13 2024, 2:13 PM
Daimona mentioned this in T350947: Performance review of Extension:WikimediaCampaignEvents.Mar 28 2024, 1:13 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits