Page MenuHomePhabricator

URL shortener doesn't take the context of the user on Special:Impact
Open, LowPublic

Description

How to reproduce:

  1. go to Special:Impact
  2. click on Get shortened URL
  3. generate the shorten URL
  4. share it with a different account

Expectation: when the other account visits the URL, they see your impact
Reality: when the other account visits the URL, the see their own impact

Cause: the URL shortener doesn't take the username into account if it is not in the URL. If you do the process with Special:Impact/Trizek, the shorten URL be my impact, not the impact of the user who uses the URL.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

What about requiring a user name to be present in the URL (and adding the viewer’s user name wherever the interface links to this page)? Special:Contributions doesn’t work without user names in URLs, but the personal toolbar links to Special:Contributions/<username>; Special:ListFiles lists all uploaded files by all users, but the link in the personal toolbar links to Special:ListFiles/<username>; and so on. Assuming the current user unless overridden in URL is confusing exactly because links cannot be shared (be they be shared using the URL shortener or by simply copy-pasting the URL from the browser URL bar).