| Maintenance_bot | |
| Nov 10 2023, 4:25 PM |
Now that T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.) is done, this extension should migrate away from building and passing around raw SQL to expression builders.
It improves readability and security of the code and is more aligned with industry practices easing onboarding.
For more information check T210206 and T350075.
Calls to Database::addQuotes(), ::buildLike(), ::makeList() indicate that raw SQL is being built and passed around.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T350075 Migrate raw SQL building in conditions to expression builder in WMF-deployed extensions | |||
| Resolved | Umherirrender | T350971 Use expression builder instead of raw SQL in FlaggedRevs | |||
| Declined | Feature | None | T29646 Implement Database util method for BETWEEN operator |
Several maintenance scripts and FlaggedRevsStats use the BETWEEN operator in raw SQL. See https://codesearch.wmcloud.org/search/?q=%5B+%5D%2BBETWEEN%5B+%5D%2B&files=&excludeFiles=&repos=Extension%3AFlaggedRevs.
Do the two provide the same performance under MariaDB? BETWEEN is more specific and thus feels to be more performant, but I can also imagine that they translate to the exact same query plan.
Based on a quick search it seems that they are identical to two queries with an AND.
Change #1037458 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/extensions/FlaggedRevs@master] Use expression builder to build where conditions
Change #1037458 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Use expression builder to build where conditions
Change #1055588 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/extensions/FlaggedRevs@master] Use expression builder to avoid IDatabase::makeList
Change #1055588 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Use expression builder to avoid IDatabase::makeList
Change #1055612 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/extensions/FlaggedRevs@master] Use expression builder instead of raw sql
Change #1055612 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Use expression builder instead of raw sql