Page MenuHomePhabricator

Use expression builder instead of raw SQL in PageAssessments
Closed, ResolvedPublic

Description

Now that T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.) is done, this extension should migrate away from building and passing around raw SQL to expression builders.

It improves readability and security of the code and is more aligned with industry practices easing onboarding.

For more information check T210206 and T350075.

Calls to Database::addQuotes(), ::buildLike(), ::makeList() indicate that raw SQL is being built and passed around.

Event Timeline

Change #1024787 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PageAssessments@master] Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1024787

Change #1024787 merged by jenkins-bot:

[mediawiki/extensions/PageAssessments@master] Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1024787