Page MenuHomePhabricator
Create Task
Maniphest T351055

BrokenRedirects does not allow distinguishing between existing and non-existing pages
Closed, ResolvedPublicBUG REPORT
Actions

Description

If you look at https://en.wikipedia.org/wiki/Special:BrokenRedirects or https://ru.wikipedia.org/wiki/Special:BrokenRedirects you can not tell the redirect to existing page from the redirect to non-existing page (as on 2023-11-13 enwiki page lists two redirects Wikipedia:VAND (which has been fixed) and Wikipedia:Example of a broken redirect (which is intentionally leads to red link) but visually they look the same way. On the ruwiki page when I'm writting this passage first redirects is working normally, second has been deleted and third points to deleted page. At least a week ago this feature worked as expected, but as far as I can see on 10th of November (after installing 1.42.0-wmf.4 version?) it has been broken.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
SpecialBrokenRedirects: Load redirect data in batch from databaseUmherirrendermediawiki/coremaster+34 -24
SpecialBrokenRedirects: Load redirect data in batch from databaseKrinklemediawiki/coreREL1_44+34 -24
SpecialBrokenRedirects: Batch and preload destination title infoKrinklemediawiki/coreREL1_44+49 -4
SpecialBrokenRedirects: Batch and preload destination title infoKrinklemediawiki/coremaster+49 -4
SpecialBrokenRedirects: Dedupe logic via private getRedirectTarget helperKrinklemediawiki/coremaster+41 -46
Improve BrokenRedirects displayPpperymediawiki/coremaster+10 -4
Improve BrokenRedirects displayUmherirrendermediawiki/coreREL1_44+10 -4
Improve BrokenRedirects displayUmherirrendermediawiki/coreREL1_43+10 -4
Improve BrokenRedirects displayUmherirrendermediawiki/coreREL1_42+10 -4
Customize query in gerrit

Related Objects

Event Timeline

WindEwriX created this task.Nov 13 2023, 7:37 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 13 2023, 7:37 AM
Aklapper added a comment.Nov 13 2023, 11:25 AM

@WindEwriX: Thanks for reporting this. For future reference, please use the bug report form (linked from the top of the task creation page) to create a bug report, and fill in the sections in the template, instead of deleting them. Thanks.

Aklapper renamed this task from Broken redirects functionality is broken to BrokenRedirects does not allow distinguishing between existing and non-existing pages.Nov 13 2023, 11:25 AM
MJL subscribed.Dec 30 2023, 8:07 PM
Bugreporter2 triaged this task as Low priority.Jan 24 2025, 4:28 AM
Pppery added a project: MediaWiki-Special-pages.May 12 2025, 4:56 PM
Pppery moved this task from To triage to Maintenance reports on the MediaWiki-Special-pages board.
Pppery mentioned this in T393933: BrokenRedirects strikes entries that are actually broken.
Pppery merged a task: T393933: BrokenRedirects strikes entries that are actually broken.May 18 2025, 1:11 AM
Pppery subscribed.

Only seems to happen if MiserMode is set.

Pppery added a comment.May 18 2025, 1:22 AM

This is a regression from https://gerrit.wikimedia.org/r/c/mediawiki/core/+/970344

gerritbot added a comment.May 18 2025, 1:49 AM

Change #1147128 had a related patch set uploaded (by Pppery; author: Pppery):

[mediawiki/core@master] Improve BrokenRedirects display

https://gerrit.wikimedia.org/r/1147128

gerritbot added a project: Patch-For-Review.May 18 2025, 1:49 AM
Reedy added projects: MW-1.42-release, MW-1.43-release, MW-1.44-release.May 18 2025, 7:36 PM
Aklapper added a project: Regression.May 18 2025, 9:30 PM
gerritbot added a comment.Jun 3 2025, 8:51 PM

Change #1153356 had a related patch set uploaded (by Umherirrender; author: Pppery):

[mediawiki/core@REL1_44] Improve BrokenRedirects display

https://gerrit.wikimedia.org/r/1153356

gerritbot added a comment.Jun 3 2025, 8:51 PM

Change #1153357 had a related patch set uploaded (by Umherirrender; author: Pppery):

[mediawiki/core@REL1_43] Improve BrokenRedirects display

https://gerrit.wikimedia.org/r/1153357

gerritbot added a comment.Jun 3 2025, 8:53 PM

Change #1153358 had a related patch set uploaded (by Umherirrender; author: Pppery):

[mediawiki/core@REL1_42] Improve BrokenRedirects display

https://gerrit.wikimedia.org/r/1153358

gerritbot added a comment.Jun 3 2025, 9:24 PM

Change #1147128 merged by jenkins-bot:

[mediawiki/core@master] Improve BrokenRedirects display

https://gerrit.wikimedia.org/r/1147128

gerritbot added a comment.Jun 3 2025, 9:39 PM

Change #1153358 merged by jenkins-bot:

[mediawiki/core@REL1_42] Improve BrokenRedirects display

https://gerrit.wikimedia.org/r/1153358

gerritbot added a comment.Jun 3 2025, 9:44 PM

Change #1153357 merged by jenkins-bot:

[mediawiki/core@REL1_43] Improve BrokenRedirects display

https://gerrit.wikimedia.org/r/1153357

gerritbot added a comment.Jun 3 2025, 9:44 PM

Change #1153356 merged by jenkins-bot:

[mediawiki/core@REL1_44] Improve BrokenRedirects display

https://gerrit.wikimedia.org/r/1153356

Umherirrender closed this task as Resolved.Jun 3 2025, 9:45 PM
Umherirrender assigned this task to Pppery.
ReleaseTaggerBot added projects: MW-1.44-notes, MW-1.43-notes, MW-1.42-notes, MW-1.45-notes (1.45.0-wmf.5; 2025-06-10).Jun 3 2025, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 3 2025, 10:31 PM
gerritbot added a comment.Jun 3 2025, 10:35 PM

Change #1153381 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] SpecialBrokenRedirects: Batch and preload destination title info

https://gerrit.wikimedia.org/r/1153381

gerritbot added a project: Patch-For-Review.Jun 3 2025, 10:35 PM
gerritbot added a comment.Jun 4 2025, 1:44 AM

Change #1153416 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] SpecialBrokenRedirects: Dedupe logic via private getRedirectTarget helper

https://gerrit.wikimedia.org/r/1153416

gerritbot added a comment.Jun 5 2025, 7:42 PM

Change #1153381 merged by jenkins-bot:

[mediawiki/core@master] SpecialBrokenRedirects: Batch and preload destination title info

https://gerrit.wikimedia.org/r/1153381

gerritbot added a comment.Jun 5 2025, 8:06 PM

Change #1153416 merged by jenkins-bot:

[mediawiki/core@master] SpecialBrokenRedirects: Dedupe logic via private getRedirectTarget helper

https://gerrit.wikimedia.org/r/1153416

Maintenance_bot removed a project: Patch-For-Review.Jun 5 2025, 8:31 PM
A_smart_kitten subscribed.Jun 10 2025, 7:16 AM
In T351055#10888877, @gerritbot wrote:

Change #1153381 merged by jenkins-bot:

[mediawiki/core@master] SpecialBrokenRedirects: Batch and preload destination title info

https://gerrit.wikimedia.org/r/1153381

For clarity, should this patch also be backported?

Pppery added a comment.Jun 10 2025, 3:55 PM

No idea. I didn't make the decision to backport the original patch, and don't care myself since this only affects me on WMF wikis.

gerritbot added a comment.Jun 10 2025, 5:55 PM

Change #1154113 had a related patch set uploaded (by Krinkle; author: Umherirrender):

[mediawiki/core@master] SpecialBrokenRedirects: Load redirect data in batch from database

https://gerrit.wikimedia.org/r/1154113

gerritbot added a project: Patch-For-Review.Jun 10 2025, 5:55 PM
A_smart_kitten added a comment.Jun 19 2025, 9:44 AM
In T351055#10898169, @A_smart_kitten wrote:
In T351055#10888877, @gerritbot wrote:

Change #1153381 merged by jenkins-bot:

[mediawiki/core@master] SpecialBrokenRedirects: Batch and preload destination title info

https://gerrit.wikimedia.org/r/1153381

For clarity, should this patch also be backported?

For the record, the answer to this question was that this patch doesn't seem like it needs to be backported: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1153381/comments/7b0f6496_4393ac04

gerritbot added a comment.Jun 23 2025, 2:20 AM

Change #1162639 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@REL1_44] SpecialBrokenRedirects: Batch and preload destination title info

https://gerrit.wikimedia.org/r/1162639

gerritbot added a comment.Jun 23 2025, 2:23 AM

Change #1162642 had a related patch set uploaded (by Krinkle; author: Umherirrender):

[mediawiki/core@REL1_44] SpecialBrokenRedirects: Load redirect data in batch from database

https://gerrit.wikimedia.org/r/1162642

gerritbot added a comment.Jun 23 2025, 2:38 AM

Change #1154113 merged by jenkins-bot:

[mediawiki/core@master] SpecialBrokenRedirects: Load redirect data in batch from database

https://gerrit.wikimedia.org/r/1154113

gerritbot added a comment.Jun 23 2025, 2:38 AM

Change #1162639 merged by jenkins-bot:

[mediawiki/core@REL1_44] SpecialBrokenRedirects: Batch and preload destination title info

https://gerrit.wikimedia.org/r/1162639

gerritbot added a comment.Jun 23 2025, 2:44 AM

Change #1162642 merged by jenkins-bot:

[mediawiki/core@REL1_44] SpecialBrokenRedirects: Load redirect data in batch from database

https://gerrit.wikimedia.org/r/1162642

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.7; 2025-06-24); removed: MW-1.45-notes (1.45.0-wmf.5; 2025-06-10).Jun 23 2025, 3:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 23 2025, 3:30 AM
Bugreporter2 subscribed.Jul 7 2025, 8:45 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits