| thcipriani | |
| Nov 13 2023, 5:31 PM |
| F41507554: gerrit-motd-banner.webm | |
| Nov 15 2023, 10:56 AM |
| F41502737: 2023-10-20_gerrit-motd_480.png | |
| Nov 13 2023, 5:31 PM |
For the last developer satisfaction survey, we added a banner at the top of https://gitlab.wikimedia.org
It would be nice to do the same thing for Gerrit.
Likewise, we make maintenance announcements, etc. In GitLab.
There's an upstream plugin: https://gerrit.googlesource.com/plugins/motd/
And it seems to work:
But I'm unclear if it's maintained.
Change 974166 had a related patch set uploaded (by Hashar; author: Hashar):
[operations/software/gerrit@deploy/wmf/stable-3.5] Add a banner for the 2023 developer survey
I gave it a try with a few lines of JavaScript to inject a message and have it fade and vanish after 12 seconds:
Change 974166 merged by jenkins-bot:
[operations/software/gerrit@deploy/wmf/stable-3.5] Add a banner for the 2023 developer survey
Mentioned in SAL (#wikimedia-operations) [2023-12-13T03:41:00Z] <hashar@deploy2002> Started deploy [gerrit/gerrit@9bf8914]: Add a banner for the 2023 developer survey - T351109
Mentioned in SAL (#wikimedia-operations) [2023-12-13T03:41:08Z] <hashar@deploy2002> Finished deploy [gerrit/gerrit@9bf8914]: Add a banner for the 2023 developer survey - T351109 (duration: 00m 08s)
The Javascript plugin attaches to the banner endpoint. The attached element fades out via a css animation and I have added a Dismiss button which store wm-motd-2023-dev-survey_dismiss = dismiss to store the intent of not showing up the banner again.
After @thcipriani had setup the test environment he made some change and I have deployed it :)
To remove the banner later, we would need to add a feature flag in order to be able to turn it off.
The Gerrit plugin displaying the banner has been removed by https://gerrit.wikimedia.org/r/c/operations/software/gerrit/+/987995
End users who dismissed the banner have a wm-motd-2023-dev-survey_dismiss = dismiss left behind in their local storage. Then I don't think it is going to cause any issue.
Change #1100162 had a related patch set uploaded (by Thcipriani; author: Hashar):
[operations/software/gerrit@deploy/wmf/stable-3.10] Add a banner for the 2024 developer survey
Change #1100162 abandoned by Thcipriani:
[operations/software/gerrit@deploy/wmf/stable-3.10] Add a banner for the 2024 developer survey
Reason:
Working version at https://gerrit.wikimedia.org/r/1100163