Currently hover your mouse cursor over a disabled button there's still visual effect.
Version: unspecified
Severity: minor
liangent | |
Dec 14 2011, 4:14 PM |
F8489: diff.txt | |
Nov 22 2014, 12:01 AM |
Currently hover your mouse cursor over a disabled button there's still visual effect.
Version: unspecified
Severity: minor
Patch fixing it
(I am new to this project and I do not know how it works much.)
To see how it worked, I decided to try to fix a bug. I am sending the svn diff resulting text. It works for me, tested on Firefox 8 and since it's standard CSS it should work everywhere.
I have tried to follow the coding style in the file, however, I do not know if I've done it OK.
It basically adds a :hover event to the disabled buttons, which sets the border to transparent with !important to override the border-color set by the other :hover event.
Attached:
By the way, I do not know if cursor should be set to normal when hovering. (I believe) now when hovering over normal buttons sets it to pointer; I do not know if this is considered "visual effect". In any case, it would be adding cursor:default !important; after the line I added.
Krinkle says:
Why the !important rule ? The need for that rule is very rare I don't think this is one of those cases. CSS cascades the rules down later rules overwrite earlier ones. Since this rule has the same "score" (or "weight") as the :hover rule for normal buttons, this should work just fine. .es-toolbarButtonTool:hover, .es-toolbarDropdownTool:hover {
border-color: #eeeeee;
} .es-toolbarButtonTool-disabled:hover {
border-color: transparent;
}
I'll apply this unless you object for some reason.
You're right. No problem. It was just as a double measure of safety.
Thanks for spotting this, and sorry.
(In reply to comment #5)
You're right. No problem. It was just as a double measure of safety.
Thanks for spotting this, and sorry.
Don't worry. Better safe then sorry, this one was just a little too safe :)
Mass-moving old VisualEditor tickets to the VE product. Search for this message to mass-delete bugmail.
(In reply to comment #0)
Currently hover your mouse cursor over a disabled button there's still visual
effect.
This effect has come back. In addition, the "pointer" cursor is used for disabled buttons, which seems wrong.
Related URL: https://gerrit.wikimedia.org/r/70231 (Gerrit Change Icbf9ac6cff5e3f914268fe14d1b430609dedd49e)