Maniphest T351206

ZObjectSelector: Fix clearing strategy when option isn't selected and user focuses out
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	gengh
	Nov 14 2023, 1:04 PM

Tags

Referenced Files

	F56171389: CleanShot 2024-07-02 at 15.27.58.gif
	Jul 2 2024, 1:29 PM

Subscribers

Description

Description

Steps to reproduce:

Go to https://wikifunctions.beta.wmflabs.org/wiki/Special:CreateObject
In the "type" selector, type String
Instead of selecting the option "String", simply focus out

Observed behavior:

The field looks like a value is selected

Expected behavior (Acceptance criteria):

If the written value matches exactly an available option, select it
If the written value does not match any available option, clear the field

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Front-end_Task/Bug_Completion_Checklist

Details

	Subject	Repo	Branch	Lines +/-
	Fix ZObjectSelector clear strategy	mediawiki/extensions/WikiLambda	master	+205 -13
	Fix zObjectSelector clear strategy	mediawiki/extensions/WikiLambda	master	+33 -4

Customize query in gerrit

Related Objects

Mentioned In: T345547: ZObjectSelector epic: Fix bugs and add behavioral improvements

Event Timeline

gengh created this task.Nov 14 2023, 1:04 PM

gengh claimed this task.Nov 14 2023, 1:06 PM

gengh mentioned this in T345547: ZObjectSelector epic: Fix bugs and add behavioral improvements.

Jdforrester-WMF changed the task status from Open to In Progress.Nov 30 2023, 5:38 PM

Jdforrester-WMF triaged this task as Medium priority.

Jdforrester-WMF moved this task from To Triage to In Progress on the Abstract Wikipedia team board.

Change #1018758 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Fix zObjectSelector clear strategy

https://gerrit.wikimedia.org/r/1018758

gerritbot added a project: Patch-For-Review.Apr 10 2024, 6:03 PM

Change #1018758 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix zObjectSelector clear strategy

https://gerrit.wikimedia.org/r/1018758

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Apr 10 2024, 9:00 PM

Change #1019688 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] [WIP] Fix ZObjectSelector clear strategy

https://gerrit.wikimedia.org/r/1019688

Jdforrester-WMF moved this task from In Progress to 24Q4 (Apr–Jun) on the Abstract Wikipedia team board.Apr 29 2024, 5:56 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team (24Q4 (Apr–Jun)); removed Abstract Wikipedia team.

Jdforrester-WMF moved this task from Incoming to In Progress on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.

Jdforrester-WMF removed a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).

Jdforrester-WMF moved this task from 24Q4 (Apr–Jun) to 25Q1 (Jul–Sep) on the Abstract Wikipedia team board.Jun 25 2024, 2:55 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q1 (Jul–Sep)); removed Abstract Wikipedia team (24Q4 (Apr–Jun)).

Jdforrester-WMF moved this task from Incoming to Bugs to investigate on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.Jun 25 2024, 6:12 PM

it seems that everything is working as expected. the only minor thing that i've noticed is the following:

focus a zobject selector
- the menu item is displayed, with the item selected set to font weight regular
delete some characters
- the menu item is updated, with the search query highlighted in bold
escape focus
original content is restored
re-focus the zobject selector
the menu item is still with the query highlighted in bold

CleanShot 2024-07-02 at 15.27.58.gif (495×800 px, 541 KB)

Change #1019688 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix ZObjectSelector clear strategy

https://gerrit.wikimedia.org/r/1019688

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.13; 2024-07-09).Jul 4 2024, 3:00 PM

Jdforrester-WMF moved this task from Bugs to investigate to Ready to deploy on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.Jul 8 2024, 8:24 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 9 2024, 8:46 PM

Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.Jul 10 2024, 4:48 PM

Jdforrester-WMF closed this task as Resolved.Jul 18 2024, 3:05 PM