Page MenuHomePhabricator
Create Task
Maniphest T351234

Mentorship: Remove blocked users from Mentorship
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

This became known this while working on T330071: Mentorship: ensure that all mentees are assigned to an active mentor.

When a mentor retires, we reassign all their mentees to a different mentor, including mentees who happen to be currently blocked (whether temporarily or indefinitely). This is likely not necessary, and it sometimes causes confusion.

Recommendation: Silently drop the mentor/mentee relationship (if the block is lifted and user visits Special:Homepage again, they'd get a new mentor automatically).

Acceptance Criteria:

Given a mentee account is blocked,
Then silently drop the mentor/mentee relationship
If the block is lifted and the user visits Special:Homepage again, they'll receive a new mentor automatically.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Mentorship: Remove indefinitely blocked mentees from mentorshipmediawiki/extensions/GrowthExperimentsmaster+128 -30
refactor: Drop MentorManager::getEffectiveMentorForUsermediawiki/extensions/GrowthExperimentsmaster+5 -35
refactor: Drop MentorManager::getMentorForUsermediawiki/extensions/GrowthExperimentsmaster+20 -86
refactor: Rename MentorPageMentorManager to a more descriptive namemediawiki/extensions/GrowthExperimentsmaster+541 -548
refactor: Streamline MentorPageMentorManagermediawiki/extensions/GrowthExperimentsmaster+78 -58
block: Introduce AbstractBlock::isIndefinitemediawiki/coremaster+30 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm_WMF created this task.Nov 14 2023, 3:51 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 14 2023, 3:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm_WMF triaged this task as Low priority.Nov 14 2023, 3:51 PM
Urbanecm_WMF moved this task from Inbox to Needs Discussion on the Growth-Team board.
Urbanecm_WMF added a parent task: T330071: Mentorship: ensure that all mentees are assigned to an active mentor.
Urbanecm_WMF mentioned this in T330071: Mentorship: ensure that all mentees are assigned to an active mentor.Nov 14 2023, 3:54 PM
KStoller-WMF renamed this task from Mentorship: Determine what to do with blocked users when reassignment to Mentorship: Remove blocked users from Mentorship.Nov 14 2023, 11:23 PM
KStoller-WMF updated the task description. (Show Details)
KStoller-WMF moved this task from Needs Discussion to Backlog on the Growth-Team board.
Johannnes89 subscribed.Mar 21 2024, 7:12 AM

@Urbanecm_WMF any updates on this? I just removed an indefinitely blocked mentor and out of the 29 reassigned mentees 5 were indef. blocked themselves and didn't need to be reassigned.
https://de.wikipedia.org/w/index.php?title=Spezial:Logbuch&page=&tagfilter=&type=growthexperiments&user=Johannnes89&wpFormIdentifier=logeventslist&wpdate=&wpfilters%5B0%5D=newusers&dir=prev&offset=20230823062151%7C136835236&limit=29

KStoller-WMF raised the priority of this task from Low to Medium.Mar 25 2024, 3:50 PM
KStoller-WMF moved this task from Backlog to Estimated tasks backlog on the Growth-Team board.
KStoller-WMF subscribed.

Noting that this is coming up again: https://www.mediawiki.org/wiki/Topic:Y1i0b8hxabalbk01

How can I remove a blocked/locked mentee from my mentorship?

I've increased the priority of this task, and I'll see if engineers can give this task an estimate so we can decide when we can fit it in.

Etonkovidova subscribed.EditedMar 27 2024, 3:59 PM

I checked the current behavior (cswiki beta).

Regarding the issue reported in Removing a blocked/locked mentee:

  • the Block counter correctly displays the number of blocks
  • the updates on Special:MentorDashboard appear after ~3 hours after the block was set (the expected behavior)

Screen Shot 2024-03-26 at 10.04.08 PM.png (1×1 px, 212 KB)

Other notes:

  • Special:MentorDashboard doesn't sufficiently inform mentors about delays in displaying updates; it might be confusing for mentors to see the changes immediately in Recent changes by your mentees but not in Your mentees table.
  • limited time blocks don't remove mentees from Special:MentorDashboard
  • an email for praising mentees comes before the information appears in Send praise module
  • are we sure that any type of blocks (even partial, time-limited blocks) should remove mentees from mentor-mentees relationship?
KStoller-WMF moved this task from Estimated tasks backlog to Backlog on the Growth-Team board.Apr 15 2024, 6:34 PM
KStoller-WMF moved this task from Backlog to Estimated tasks backlog on the Growth-Team board.Apr 29 2024, 6:38 PM
KStoller-WMF moved this task from Estimated tasks backlog to Backlog on the Growth-Team board.Oct 9 2024, 4:44 PM
KStoller-WMF moved this task from New Tasks to Prioritized on the GrowthExperiments-Mentorship board.Oct 17 2024, 1:43 PM
Pppery merged a task: T382792: Mentorship: Add possibility to remove blocked mentees (users).Dec 27 2024, 5:40 PM
Pppery added subscribers: Kizule, Pppery, Milicevic01, FriedrickMILBarbarossa.
Pppery unsubscribed.
FriedrickMILBarbarossa awarded a token.Dec 27 2024, 5:46 PM
Milicevic01 awarded a token.Dec 28 2024, 2:13 AM
Bugreporter subscribed.EditedDec 28 2024, 2:35 AM

Note this should also apply to mentors/mentees who are globally blocked or globally locked. This will also remove vanished users from mentorship.

Pppery added a comment.Dec 28 2024, 4:13 AM

This task is about blocked mentees. Blocked mentors were handled by T317148

Trizek-WMF subscribed.Jan 6 2025, 6:58 PM

New request.

1AmNobody24 subscribed.Jan 7 2025, 2:15 PM
Urbanecm_WMF updated the task description. (Show Details)Jan 23 2025, 4:10 PM

This seems to be doable via https://www.mediawiki.org/wiki/Manual:Hooks/BlockIpComplete.

KStoller-WMF moved this task from Backlog to Estimated tasks backlog on the Growth-Team board.Jan 31 2025, 9:30 PM
KStoller-WMF set the point value for this task to 2.Feb 4 2025, 5:18 PM
KStoller-WMF moved this task from Estimated tasks backlog to Current Sprint on the Growth-Team board.Feb 4 2025, 5:50 PM
KStoller-WMF edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
Urbanecm_WMF claimed this task.Feb 5 2025, 3:38 PM
Urbanecm_WMF moved this task from Incoming to Doing on the Growth-Team (Current Sprint) board.
gerritbot added a comment.Feb 11 2025, 1:21 PM

Change #1118807 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Mentorship: Remove indefinitely blocked mentees from mentorship

https://gerrit.wikimedia.org/r/1118807

gerritbot added a project: Patch-For-Review.Feb 11 2025, 1:21 PM
gerritbot added a comment.Feb 12 2025, 12:47 PM

Change #1119100 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] refactor: Streamline MentorPageMentorManager

https://gerrit.wikimedia.org/r/1119100

gerritbot added a comment.Feb 12 2025, 4:05 PM

Change #1119172 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Refactor: Rename MentorPageMentorManager to a more descriptive name

https://gerrit.wikimedia.org/r/1119172

gerritbot added a comment.Feb 12 2025, 5:18 PM

Change #1119175 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] refactor: Drop MentorManager::getMentorForUser

https://gerrit.wikimedia.org/r/1119175

gerritbot added a comment.Feb 12 2025, 5:18 PM

Change #1119189 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] refactor: Drop MentorManager::getEffectiveMentorForUserSafe

https://gerrit.wikimedia.org/r/1119189

gerritbot added a comment.Feb 12 2025, 7:15 PM

Change #1119203 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@master] block: Introduce AbstractBlock::isIndefinite

https://gerrit.wikimedia.org/r/1119203

Urbanecm_WMF moved this task from Prioritized to In Progress on the GrowthExperiments-Mentorship board.Feb 12 2025, 7:21 PM
Urbanecm_WMF moved this task from Doing to Code Review on the Growth-Team (Current Sprint) board.
gerritbot added a comment.Feb 14 2025, 6:55 PM

Change #1119203 merged by jenkins-bot:

[mediawiki/core@master] block: Introduce AbstractBlock::isIndefinite

https://gerrit.wikimedia.org/r/1119203

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.17; 2025-02-18).Feb 14 2025, 7:00 PM
Urbanecm_WMF mentioned this in T386567: ApiHelpPanelPostQuestion throws an unhandled exception on invalid API calls.Feb 15 2025, 11:09 PM
gerritbot added a comment.Feb 17 2025, 12:21 PM

Change #1119100 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] refactor: Streamline MentorPageMentorManager

https://gerrit.wikimedia.org/r/1119100

gerritbot added a comment.Feb 17 2025, 1:40 PM

Change #1119172 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] refactor: Rename MentorPageMentorManager to a more descriptive name

https://gerrit.wikimedia.org/r/1119172

gerritbot added a comment.Feb 17 2025, 1:40 PM

Change #1119175 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] refactor: Drop MentorManager::getMentorForUser

https://gerrit.wikimedia.org/r/1119175

gerritbot added a comment.Feb 17 2025, 2:25 PM

Change #1119189 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] refactor: Drop MentorManager::getEffectiveMentorForUser

https://gerrit.wikimedia.org/r/1119189

gerritbot added a comment.Feb 17 2025, 2:25 PM

Change #1118807 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentorship: Remove indefinitely blocked mentees from mentorship

https://gerrit.wikimedia.org/r/1118807

Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Feb 17 2025, 6:16 PM

QA note: As part of this task, we did quite a lot of mentorship-related refactoring. It is possible random regressions related to mentor list and mentor assignment would happen here and there.

Urbanecm_WMF removed a project: Patch-For-Review.Feb 17 2025, 6:25 PM
Etonkovidova added a comment.EditedFeb 18 2025, 11:55 PM

Tested on enwiki beta - the test results are in the table

User type blockMentorship dropped?When unblocked
Case 1 user 1 - Sitewide, IndefiniteYes - a blocked user doesn't see Mentorship module; a mentor doesn't see the blocked useran un-blocked user sees a new mentor
Case 2 user 2 - Sitewide, with expiration dateNo - a user still sees Mentorship module; a mentor sees the blocked user. Attempting to send a message from Special:Homepage results in the error message:
Screen Shot 2025-02-18 at 3.37.51 PM.png (1×1 px, 211 KB)
an un-blocked user gets a mentor
Case 3 user 3 - Partial, indefiniteYes - a blocked user doesn't see Mentorship module; a mentor doesn't see the blocked useran un-blocked user sees a new mentor
Case 4 user 4 - Partial, with expiration dateNo - a user still sees Mentorship module; a mentor sees the blocked user. Sending a message to a mentor from Special:Homepage is successful.an un-blocked user gets a mentor
Etonkovidova closed this task as Resolved.Feb 19 2025, 4:02 PM
Myrealnamm subscribed.Feb 19 2025, 9:09 PM

My blocked mentee was removed from my Mentorship Dashboard at the enwiki. Are any of the four results posted above implemented at the enwiki now?

Etonkovidova added a comment.Feb 20 2025, 12:19 AM
In T351234#10565637, @Myrealnamm wrote:

My blocked mentee was removed from my Mentorship Dashboard at the enwiki. Are any of the four results posted above implemented at the enwiki now?

The patches in this task will be deployed to wmf.17, so those changes are scheduled to be on enwiki` on Feb 20 The existing behavior - blocked mentees are removed from MentorDashboard - was in place before, but this task makes dropping mentor/mentee relationship consistent (for different types of user blocks) and makes such changes appear promptly.

Urbanecm_WMF mentioned this in T392280: Mentorship: Preserve Mentor-Mentee connection after temporary blocks.May 3 2025, 8:58 PM
Urbanecm_WMF mentioned this in T400738: Vanished users should not be reassigned mentors.Aug 22 2025, 2:20 PM
Mathglot subscribed.Feb 16 2026, 12:27 PM
Trizek-WMF mentioned this in T418992: A blocked user shouldn't get a new mentor when their original mentor quits.Mar 4 2026, 11:06 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits