Page MenuHomePhabricator

Assignment script log comment should be improved
Open, MediumPublic2 Estimated Story Points

Description

At the log page on wikis, we can find the reassignement performed by T330071: Mentorship: ensure that all mentees are assigned to an active mentor.
It says:

06:41, 14 November 2023 Martin Urbanec (WMF) talk contribs set Kinvidia as the mentor of FPS First Place Stunna (previous mentor Nosebagbear) (Nosebagbear retired from mentorship.)

In the case of Nosebagbear, as we all know, he hasn't strictly "retired from mentorship".

The comment should:

  1. convey that the process is automated
  2. reassibnement is due to a neutral reason

Suggested wording:

"Automated reassignment of mentees since $oldmentor is no longer a mentor"

Event Timeline

Urbanecm_WMF set the point value for this task to 2.Nov 14 2023, 11:34 PM

@Trizek-WMF Hello, thanks for filling this task! There is a second, similar, message used when an admin removes a mentor using Special:ManageMentors. Currently, it reads $admin removed $oldmentor from mentorship. Do you think we should update that message as well? If so, would Automated reassignment of mentees since $admin removed $oldmentor from mentorship work? Or would you prefer if we use a different copy for that scenario?

For the script, the idea is to clearly convey that it is an automated process.
It would say "Automated reassignment of mentees since $oldmentor is no longer an active mentor"

When an admin reassigns mentees, I would consider it more as any other admin action, even if it can impact 2k users.
It would say "$admin reassigned $oldmentor's mentees since they are no longer an active mentor"

Thanks for the reply. Does that mean that in this task, the message should only change for the (one-off) T330071 reassignment? I originally understood it as change the message for any mentor/mentee reassignment (whether done by the script, or by a mentor quitting themselves, or by an admin removing). But, maybe I got that incorrectly.

@Trizek-WMF Hello, thanks for filling this task! There is a second, similar, message used when an admin removes a mentor using Special:ManageMentors. Currently, it reads $admin removed $oldmentor from mentorship. Do you think we should update that message as well? If so, would Automated reassignment of mentees since $admin removed $oldmentor from mentorship work? Or would you prefer if we use a different copy for that scenario?

I don't think we need "automated" here, however, maybe it would be useful to signify that this is a bulk/mass action (especially if ~2k actions are being made)? Maybe Bulk reassignment of mentees since $admin removed $oldmentor from mentorship

Thanks for the reply. Does that mean that in this task, the message should only change for the (one-off) T330071 reassignment? I originally understood it as change the message for any mentor/mentee reassignment (whether done by the script, or by a mentor quitting themselves, or by an admin removing). But, maybe I got that incorrectly.

Yes, the message I suggest is for the one-off reassignment. Based on the feedback received, it would say "Mass reassignment of mentees since $oldmentor is no longer an active mentor" for clarity (tweaked based on Soda's feedback below).

If we want to change the message for the regular process, aka when any admin removes a mentee from the list, we can keep what is already in service (it hasn't raised any feedback), or consider to write "$admin reassigned $oldmentor's mentees since they are no longer an active mentor". I'm more in favor of "if not broken, don't fix".

If we go with one sentence for both, maybe "Mass reassignment of mentees since $oldmentor is no longer an active mentor". After all, the mass reassignment performed by an admin has the admin name in the different logs, no?

I don't think we need "automated" here, however, maybe it would be useful to signify that this is a bulk/mass action (especially if ~2k actions are being made)? Maybe Bulk reassignment of mentees since $admin removed $oldmentor from mentorship

Good point. We have to be careful of translatability/interpretability, as this message will be displayed to many communities, where users have various knowledge of the English language. I think "Mass reassignment" would be clearer thank "Bulk".