Page MenuHomePhabricator

Create a Grafana chart to plot the number of checked and unchecked images per wiki
Closed, ResolvedPublic2 Estimated Story Points

Description

Grafana chart(s) should be created that details the number of unchecked and checked images per wiki which should be updated at least daily. This data would come from the mediamoderation_scan table. Alerts should be setup that fire if the number of unchecked images is growing out of control.

Acceptance criteria

Event Timeline

Change 981634 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MediaModeration@master] Add updateMetrics.php maintenance script along with statds support

https://gerrit.wikimedia.org/r/981634

Change 981634 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MediaModeration@master] Add updateMetrics.php maintenance script along with statds support

https://gerrit.wikimedia.org/r/981634

@STran This patch is not meant for this task - it's now tagged against the subtask T353074: Create a maintenance script to publish to statsd metrics about the mediamoderation_scan table

Change 981634 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MediaModeration@master] Add updateMetrics.php maintenance script along with statds support

https://gerrit.wikimedia.org/r/981634

@STran This patch is not meant for this task - it's now tagged against the subtask T353074: Create a maintenance script to publish to statsd metrics about the mediamoderation_scan table

Agreed. This was just me accidentally tagging the wrong task.

Specific graphs:

  • Unchecked/Checked over total number of images in the table as a rate of change
  • Images that couldn't be checked as a rate of change (see getStatsdKey())
  • How long does a request take (average? distribution)
  • How many success/error returned (bar graph)
  • Response codes (from API on successful call) returned (bar graph)

See:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MediaModeration/+/983180/
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MediaModeration/+/981634/

I've updated the dashboard based on the recommendations from https://wikitech.wikimedia.org/wiki/Grafana/Best_practices. The major changes I've made are:

  • Added the thumbnail transform time graph (I missed this when discussing this ticket with STran).
  • Converted the API request time histogram to a line graph per the best practices saying For timing metrics, use a line chart.
  • I've moved it to a Trust and Safety Product folder for ease of finding it in the future.

Otherwise this looks good to me. Thanks for creating this.

Dreamy_Jazz set the point value for this task to 2.Jan 3 2024, 10:36 AM

I think this can be moved to Done now as the dashboard looks good to me and QA isn't needed for this.

I added a $wiki variable and updated the charts to make use of it (see version 18 here). That allows you to query by all wikis, or to inspect data for specific wikis (e.g. testwiki).

I added a $wiki variable and updated the charts to make use of it (see version 18 here). That allows you to query by all wikis, or to inspect data for specific wikis (e.g. testwiki).

Thanks.