Page MenuHomePhabricator

Render client preferences serverside
Closed, DeclinedPublic

Description

Description

Currently we use JS to render the client prefs form. This could easily be done with mustache instead, which is needed for the new design in https://phabricator.wikimedia.org/T350612.

todo

  • Revisit the approach outlined in T349938 and revise the proof of concept to determine how this would work for Minerva.
  • templates are used to render client prefs
  • client pref radio buttons are disabled until JS kicks in
  • client prefs are hidden when JS is disabled

Event Timeline

Jdlrobson triaged this task as Medium priority.Nov 17 2023, 7:51 PM

This seems like it would be a significant change, and we still need to think out how this would impact the mobile site. Given it is not a blocker for deploying to beta, I recommend punting this ticket until after the beta has been released.

I don't think there's strong motivation or time to do this. If we still want to do it, we should create a new ticket with the new phabricator template to capture motivation.