Page MenuHomePhabricator

Search bars should have magnifying glasses on mobile
Closed, ResolvedPublic2 Estimated Story Points

Description

NOTE: Please consider T285356 while fixing and in QA. Might be fixed by T346162.

When I open the language overlay I see:

image.png (480×320 px, 22 KB)

When I focus the search input the magnifying glass disappear

Screenshot 2023-11-17 at 12.13.39 PM.png (48×391 px, 4 KB)

Screenshot 2023-11-17 at 12.13.25 PM.png (48×419 px, 4 KB)

Looking at the code it looks like we used to have an icon here and we may have broken it.

@JScherer-WMF thoughts?

sign off

QA Results - Beta

ACStatusDetails
1T351569#9530626

Event Timeline

This looks like a bug to me. Do we know how long it's been like this?

ovasileva triaged this task as Medium priority.Nov 20 2023, 2:22 PM
Jdlrobson renamed this task from Should search bars have magnifying glasses on mobile? to Search bars have magnifying glasses on mobile.Nov 27 2023, 5:24 PM
Jdlrobson raised the priority of this task from Medium to High.Dec 4 2023, 7:00 PM
Jdlrobson lowered the priority of this task from High to Medium.
Jdlrobson set the point value for this task to 2.
Jdlrobson renamed this task from Search bars have magnifying glasses on mobile to Search bars should have magnifying glasses on mobile.Dec 7 2023, 5:57 PM
Jdlrobson renamed this task from Search bars should have magnifying glasses on mobile to [Overflow] Search bars should have magnifying glasses on mobile.Feb 8 2024, 5:52 PM

Moving to next sprint per discussion in sprint today. There is a shift issue (T285356) that becomes more prominent after this change, so we're keen to address that as part of this ticket.

Jdlrobson renamed this task from [Overflow] Search bars should have magnifying glasses on mobile to [Carryover] Search bars should have magnifying glasses on mobile.Feb 8 2024, 5:53 PM

Change 999134 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[mediawiki/extensions/MobileFrontend@master] Add search icon back to overlay

https://gerrit.wikimedia.org/r/999134

SToyofuku-WMF renamed this task from [Carryover] Search bars should have magnifying glasses on mobile to Search bars should have magnifying glasses on mobile.Feb 9 2024, 12:20 AM

Change 999134 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Add search icon back to overlay

https://gerrit.wikimedia.org/r/999134

Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Search bars should have magnifying glasses on mobile when focused

screenshot 441.png (895×413 px, 14 KB)

ovasileva claimed this task.

All done!