Search bars should have magnifying glasses on mobile
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Nov 17 2023, 8:14 PM

Description

NOTE: Please consider T285356 while fixing and in QA. Might be fixed by T346162.

When I open the language overlay I see:

When I focus the search input the magnifying glass disappear

Looking at the code it looks like we used to have an icon here and we may have broken it.

@JScherer-WMF thoughts?

sign off

update T285356 if necessary

QA Results - Beta

AC	Status	Details
1	✅	T351569#9530626

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add search icon back to overlay	mediawiki/extensions/MobileFrontend	master	+9 -3

Customize query in gerrit

Related Objects

Mentioned Here: T346162: Icons rendered via JavaScript in Minerva should use Codex mixin
T285356: [tablet/desktop] Minerva search bar blurs text and moves/shrinks slightly when focussed

Event Timeline

Jdlrobson created this task.Nov 17 2023, 8:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 17 2023, 8:14 PM

This looks like a bug to me. Do we know how long it's been like this?

ovasileva triaged this task as Medium priority.Nov 20 2023, 2:22 PM

Jdlrobson edited projects, added Web-Team-Backlog-Archived (FY2023-24 Q2 Sprint 5); removed Web-Team-Backlog-Archived (Web Team FY2023-24 Q2 Sprint 4).Nov 20 2023, 6:38 PM

Jdlrobson renamed this task from Should search bars have magnifying glasses on mobile? to Search bars have magnifying glasses on mobile.Nov 27 2023, 5:24 PM

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog-Archived (FY2023-24 Q2 Sprint 5) board.Nov 30 2023, 10:27 AM

Jdlrobson updated the task description. (Show Details)Dec 1 2023, 4:46 PM

ovasileva moved this task from Ready for Development to Incoming on the Web-Team-Backlog-Archived (FY2023-24 Q2 Sprint 5) board.Dec 4 2023, 6:39 PM

Jdlrobson updated the task description. (Show Details)Dec 4 2023, 6:56 PM

Jdlrobson raised the priority of this task from Medium to High.Dec 4 2023, 7:00 PM

Jdlrobson lowered the priority of this task from High to Medium.

Jdlrobson set the point value for this task to 2.

Jdlrobson moved this task from Incoming to Blocked on Others on the Web-Team-Backlog-Archived (FY2023-24 Q2 Sprint 5) board.Dec 4 2023, 8:45 PM

Jdlrobson moved this task from Blocked on Others to Incoming on the Web-Team-Backlog-Archived (FY2023-24 Q2 Sprint 5) board.Dec 4 2023, 8:47 PM

Jdlrobson renamed this task from Search bars have magnifying glasses on mobile to Search bars should have magnifying glasses on mobile.Dec 7 2023, 5:57 PM

Jdlrobson edited projects, added Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 1); removed Web-Team-Backlog-Archived (FY2023-24 Q2 Sprint 5).Dec 19 2023, 5:51 PM

Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 1) board.Jan 4 2024, 12:21 AM

ovasileva moved this task from Ready for Development to Incoming on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 1) board.Jan 8 2024, 6:38 PM

Jdlrobson edited projects, added Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 2); removed Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 1).Jan 16 2024, 6:08 PM

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 2) board.Jan 18 2024, 2:50 PM

SToyofuku-WMF claimed this task.Feb 6 2024, 10:53 PM

Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 2) board.Feb 6 2024, 11:02 PM

Moving to next sprint per discussion in sprint today. There is a shift issue (T285356) that becomes more prominent after this change, so we're keen to address that as part of this ticket.

Jdlrobson renamed this task from [Overflow] Search bars should have magnifying glasses on mobile to [Carryover] Search bars should have magnifying glasses on mobile.Feb 8 2024, 5:53 PM

Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 3) board.Feb 8 2024, 5:57 PM

Change 999134 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[mediawiki/extensions/MobileFrontend@master] Add search icon back to overlay

https://gerrit.wikimedia.org/r/999134

gerritbot added a project: Patch-For-Review.Feb 9 2024, 12:19 AM

SToyofuku-WMF renamed this task from [Carryover] Search bars should have magnifying glasses on mobile to Search bars should have magnifying glasses on mobile.Feb 9 2024, 12:20 AM

SToyofuku-WMF edited projects, added Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 2); removed Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 3).

SToyofuku-WMF moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 2) board.Feb 9 2024, 12:22 AM

Jdlrobson reassigned this task from SToyofuku-WMF to Edtadros.Feb 9 2024, 12:36 AM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 2) board.

Jdlrobson added a subscriber: SToyofuku-WMF.

Change 999134 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Add search icon back to overlay

https://gerrit.wikimedia.org/r/999134

Maintenance_bot removed a project: Patch-For-Review.Feb 9 2024, 1:30 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Search bars should have magnifying glasses on mobile when focused

Edtadros updated the task description. (Show Details)Feb 9 2024, 10:55 PM

All done!

	F41514204: Screenshot 2023-11-17 at 12.13.25 PM.png
	Nov 17 2023, 8:14 PM

	F41514205: Screenshot 2023-11-17 at 12.13.39 PM.png
	Nov 17 2023, 8:14 PM

	F41832408: screenshot 441.png
	Feb 9 2024, 10:54 PM

Search bars should have magnifying glasses on mobileClosed, ResolvedPublic2 Estimated Story PointsActions