This task is mostly a heads-up and for documentation.
We plan to switch off the code review tool in Phabricator called Differential soon (note that this is not Diffusion for repository browsing) in order to reduce the number of common code review places from 4 to 3 (GitLab, Gerrit, some stuff on Github).
https://phabricator.wikimedia.org/herald/query/WzSA9G24mKf1/#R lists three active Herald rules related to Differential, to be disabled/archived:
- H224 by @Galahad (the action adds Galahad as blocking reviewer but Wikimedia-Small-Projects-User-Group-TechCom code repos are not canonincally hosted in Diffusion anymore)
- H102 to add Release-Engineering-Team as a reviewer
- H101 by @Krenair to notify on Scap (but Scap has Publishing Disabled anyway, so the rule is de-facto dysfunctional)
I am going to disable all these three rules. However, two rules are "Personal" rules, so I'd have to use my administrator rights to "break in" basically, as Personal rules by default can only be edited by their respective authors.