Page MenuHomePhabricator

Create new `isDevMode` Implementation
Open, Needs TriagePublic


The Soft Close was adjusted to not be shown to the user on the last impression. This is causing issues during acceptance testing because the tester is constantly required to clear their current impression count from local storage when they need to test the Soft Close events.

Acceptance Criteria

  • Always set the remaining impressions to a number above 0 when the banner is in dev mode.

Implementation Notes

  • isDevMode is checked in various places, this should be centralised and made a bit more flexible by returning an object rather than a boolean.
  • In order to keep backwards compatibility, the new object should be injected into the classes where it is used as an optional constructor parameter, then defaulted internally by the classes that need it.
  • Any methods that use a custom check for dev mode should be marked as deprecated.