Maniphest T351636

Add `temp` flag to various APIs
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The following API endpoints return information about contributions, and include an anon flag if the performer was an anonymous/IP user.

ApiQueryImageInfo
ApiQueryLogEvents
ApiQueryRecentChanges
anything that extends ApiQueryRevisionsBase

Following the decision to consider temporary users as a separate type of user in T337103: Decide a standard approach for classifying temporary, IP and registered users, we should add a temp flag to these in order to flag temporary users too.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add `temp` flags to api calls	mediawiki/core	master	+127 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
					Restricted Task
		Resolved		kostajh	T294511 2021 Security Team wikireplicas audit
		Declined		None	T284948 Raw IPs of logged-out users disclosed in wiki-replicas
		Resolved		Niharika	T324492 Temporary accounts - MVP
		Resolved		Madalina	T326816 [Epic] Update features for temporary accounts
		Resolved		Madalina	T331637 Update features in MediaWiki core for IP Masking
		Resolved		Dreamy_Jazz	T341228 Update action API to handle temporary users
		Resolved		STran	T351636 Add `temp` flag to various APIs

Event Timeline

Tchanders created this task.Nov 20 2023, 11:59 AM

Tchanders updated the task description. (Show Details)Nov 20 2023, 12:12 PM

Tchanders mentioned this in T341228: Update action API to handle temporary users.Nov 20 2023, 12:16 PM

kostajh updated the task description. (Show Details)Nov 28 2023, 2:39 PM

Tchanders set the point value for this task to 2.Nov 28 2023, 2:41 PM

Tchanders edited projects, added Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)); removed Trust and Safety Product Sprint.

STran claimed this task.Nov 29 2023, 11:03 AM

Change 979100 had a related patch set uploaded (by STran; author: STran):

[mediawiki/core@master] Add `temp` flags to api calls

https://gerrit.wikimedia.org/r/979100

gerritbot added a project: Patch-For-Review.Nov 30 2023, 1:44 PM

Tchanders moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)) board.Dec 1 2023, 2:30 PM

Tchanders edited projects, added Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023)); removed Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)).Dec 11 2023, 5:09 PM

Tchanders moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023)) board.

Change 979100 merged by jenkins-bot:

[mediawiki/core@master] Add `temp` flags to api calls

https://gerrit.wikimedia.org/r/979100

Tchanders mentioned this in T353355: Add extra tests for API `temp` flag.Dec 13 2023, 5:33 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Dec 13 2023, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 13 2023, 6:30 PM

Tchanders moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023)) board.Dec 15 2023, 11:02 PM

Tchanders mentioned this in T352839: RevertRisk model readiness for temporary accounts.Jan 2 2024, 11:25 AM

dom_walden edited projects, added Trust and Safety Product Sprint (Sprint Northumbrian smallpipes (8th Jan.‘24 - 19th Jan.'24)); removed Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023)).Jan 12 2024, 7:27 AM

dom_walden moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Northumbrian smallpipes (8th Jan.‘24 - 19th Jan.'24)) board.

I tested all the API listed in the description (using list=allrevisions and list=alldeletedrevisions as they extend ApiQueryRevisionsBase).

I tested on a wikis with and without temporary accounts enabled and saw entries for temporary, anon and named users.

Test environment: local docker MediaWiki 1.42.0-alpha (2f4e492) 07:13, 12 January 2024.

Tchanders closed this task as Resolved.Jan 30 2024, 4:51 PM

Tchanders mentioned this in T358683: Update ApiQueryUserInfo to handle temporary users.Feb 28 2024, 4:37 PM

Tchanders mentioned this in T358693: Update ApiQueryWatchlist to handle temporary users.Mar 1 2024, 7:36 PM