Page MenuHomePhabricator

Split suppression flag to be per-restriction (e.g. ability to suppress text but normal revdel reason, etc.)
Open, LowPublicFeature

Description

To quote Franamax on en:WP:VPT:

"One revision had been touched by an oversighter, who suppressed the edit summary but left the version text intact. I was not able to select this version to revision-delete the page text, as the square checkbox was greyed out. This meant that I had to leave material publicly viewable (from the page history) while I waited for further suppression at the oversighter level."

It seems that RevisionDeletion-suppressions "claims" the whole revision for oversighters, when the logical thing to do would be to claim only those properties actually suppressed by the oversighter.


Version: 1.18.x
Severity: enhancement

Details

Reference
bz33168

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:05 AM
bzimport set Reference to bz33168.
bzimport added a subscriber: Unknown Object (MLST).

On further prodding this is more difficult than I thought, because we allow admins to select multiple revisions (and hence some with and some without elements of oversight) at the same time. Not to mention the fact that going from Revision-level control to property-level control would be difficult at the best of times. Eurgh.

I think that enwiki uses version 1.18.

Any new deletion flag (comment,text) would be oversight level since the suppress flag is set. Since non-oversights can't change that flag, then they can't do anything to the revision without violating permissions.

I think that enwiki uses version 1.18.

Yes, it displays on 1.18 and 1.19svn, naturally.

Any new deletion flag (comment,text) would be oversight level since the
suppress flag is set. Since non-oversights can't change that flag, then they
can't do anything to the revision without violating permissions

The point is, if the oversighter doesn't change the deletion status of the username/summary/text/etc i.e. leaves it visible, it should be possible for admins to RevDel it. But yes, I agree that the problem with fixing this is that at the moment flags are set per-revision, when really we would need them to be sufficiently granular i.e. be set per property.

Krenair renamed this task from RevisionDeletion-suppress shouldn't claim whole revision for oversighters, only those properties suppressed to Split suppression flag to be per-restriction (e.g. ability to suppress text but normal revdel reason, etc.).Sep 21 2015, 9:24 PM
Krenair set Security to None.

Yes, I think the only way that this is happening is if the suppression flag got split up.

Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 11:00 AM
Aklapper removed a subscriber: wikibugs-l-list.