Page MenuHomePhabricator
Create Task
Maniphest T351818

Reduce number of ResourceLoader modules defined by the CampaignEvents extension
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

The extension currently defines 8 modules, 4 of which are styles; this is greatly above the recommended maximum of 3 modules. We should try and bundle these modules together, following the guidelines in https://www.mediawiki.org/wiki/ResourceLoader/Developing_with_ResourceLoader

We will combine the existing modules into 2 "SpecialPages" and "EventPages", using a dispatcher to include only the relevant javascript (see: CheckUser for an example)

CSS will need to be standardised and namespaced.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Create new stylesheet to replace inline stylesmediawiki/extensions/CampaignEventsmaster+18 -20
Merge special page styles into a single modulemediawiki/extensions/CampaignEventsmaster+16 -27
Make CSS identifiers more consistent and isolatedmediawiki/extensions/CampaignEventsmaster+228 -226
Migrate javascript modules to dispatcher model.mediawiki/extensions/CampaignEventsmaster+100 -104
Customize query in gerrit

Related Objects

Event Timeline

Daimona created this task.Nov 22 2023, 1:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 22 2023, 1:41 PM
Daimona moved this task from Backlog to Tech debt on the CampaignEvents board.Nov 22 2023, 1:41 PM
Daimona updated the task description. (Show Details)
Daimona mentioned this in T322209: Organizers choose what information they need from participants.Feb 20 2024, 11:14 PM
Daimona moved this task from Backlog to To be Estimated/Discussed on the Connection-Team board.Feb 23 2024, 4:49 PM
ifried set the point value for this task to 5.Mar 28 2024, 2:31 PM
ifried moved this task from To be Estimated/Discussed to Estimated/Ready for work on the Connection-Team board.
MHorsey-WMF updated the task description. (Show Details)Jun 20 2024, 12:35 PM
Daimona mentioned this in T364804: Display Invitation List on Special:InvitationList.Jul 11 2024, 9:52 PM
Daimona edited projects, added Connection-Team (Connection-Current-Sprint); removed Connection-Team.Jul 17 2024, 4:16 PM
Daimona moved this task from Upcoming / refining 💡 to Ready for development on the Connection-Team (Connection-Current-Sprint) board.
gerritbot added a comment.Jul 18 2024, 1:00 PM

Change #1055211 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Migrate javascript modules to dispatcher model, to minimize number of loaded resources.

https://gerrit.wikimedia.org/r/1055211

gerritbot added a project: Patch-For-Review.Jul 18 2024, 1:00 PM
gerritbot added a comment.Jul 19 2024, 3:24 PM

Change #1055211 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Migrate javascript modules to dispatcher model.

https://gerrit.wikimedia.org/r/1055211

Maintenance_bot removed a project: Patch-For-Review.Jul 19 2024, 3:31 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.15; 2024-07-23).Jul 19 2024, 4:00 PM
Daimona moved this task from Ready for development to Development In Progress 💻 on the Connection-Team (Connection-Current-Sprint) board.Jul 19 2024, 5:47 PM
gerritbot added a comment.Jul 19 2024, 8:34 PM

Change #1055487 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Make CSS identifiers more consistent and isolated

https://gerrit.wikimedia.org/r/1055487

gerritbot added a project: Patch-For-Review.Jul 19 2024, 8:34 PM
gerritbot added a comment.Jul 22 2024, 12:55 PM

Change #1055926 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Merge special page styles into a single module

https://gerrit.wikimedia.org/r/1055926

gerritbot added a comment.Jul 22 2024, 1:52 PM

Change #1055944 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Create new stylesheet to replace inline styles

https://gerrit.wikimedia.org/r/1055944

Daimona moved this task from Development In Progress 💻 to Code Review 💬 on the Connection-Team (Connection-Current-Sprint) board.Jul 22 2024, 1:52 PM
gerritbot added a comment.Jul 22 2024, 2:37 PM

Change #1055487 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Make CSS identifiers more consistent and isolated

https://gerrit.wikimedia.org/r/1055487

gerritbot added a comment.Jul 22 2024, 3:30 PM

Change #1055926 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Merge special page styles into a single module

https://gerrit.wikimedia.org/r/1055926

gerritbot added a comment.Jul 23 2024, 10:26 AM

Change #1055944 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Create new stylesheet to replace inline styles

https://gerrit.wikimedia.org/r/1055944

Maintenance_bot removed a project: Patch-For-Review.Jul 23 2024, 10:30 AM
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.16; 2024-07-30); removed MW-1.43-notes (1.43.0-wmf.15; 2024-07-23).Jul 23 2024, 11:00 AM
Daimona moved this task from Code Review 💬 to QA 🐛 on the Connection-Team (Connection-Current-Sprint) board.Jul 23 2024, 12:55 PM

We now have a total of 4 modules: event page JS, event page styles, special pages JS, special pages styles. I think it's good enough for this task. For QA, just make sure that everything is still looking good and there are no prominent client-side errors (e.g., a button that does nothing when clicked, a modal that doesn't open, or an unstyled element, etc.).

vaughnwalters subscribed.Jul 26 2024, 5:44 PM

@Daimona checking this on betacluster and everything seems fine except it doesn't seem that response statistics are compiling on betacluster anymore (so I can't check anything inside of that tab). I don't THINK this would be related to this task though would it?

vaughnwalters moved this task from QA 🐛 to QA / Dev input 💬 on the Connection-Team (Connection-Current-Sprint) board.Jul 26 2024, 5:55 PM
Daimona added a comment.Jul 26 2024, 8:13 PM
In T351818#10018995, @vaughnwalters wrote:

@Daimona checking this on betacluster and everything seems fine except it doesn't seem that response statistics are compiling on betacluster anymore (so I can't check anything inside of that tab). I don't THINK this would be related to this task though would it?

It's most likely unrelated, but can you expand on it?

vaughnwalters closed this task as Resolved.Jul 29 2024, 9:42 PM
vaughnwalters claimed this task.
vaughnwalters moved this task from QA / Dev input 💬 to Done 🏁 on the Connection-Team (Connection-Current-Sprint) board.
In T351818#10019437, @Daimona wrote:
In T351818#10018995, @vaughnwalters wrote:

@Daimona checking this on betacluster and everything seems fine except it doesn't seem that response statistics are compiling on betacluster anymore (so I can't check anything inside of that tab). I don't THINK this would be related to this task though would it?

It's most likely unrelated, but can you expand on it?

Ah, nevermind, I checked again today and the response statistics have been compiled now for this event I was testing on. Moving to done / resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits